New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

OOBE Chime plays on every sign-out

Project Member Reported by zalcorn@chromium.org, Sep 12 2017

Issue description

Jenn is hearing the OOBE chime play every time she signs out on caroline running M62: https://listnr.corp.google.com/product/208/report/72978545493
rkc@, can you assign?
 

Comment 1 by r...@chromium.org, Sep 12 2017

Cc: r...@chromium.org
Owner: alemate@chromium.org
Not on 61?

Nope not seeing this in M-61.
Cc: zalcorn@chromium.org
It looks like it was result of a bug fix. The bug was "Fix startup sound when ChromeVox is enabled". ;)
It looks like we had startup sound only on OOBE.

Is this exactly what we need?
Jenn, what is ideal experience here:
 - Play sound only on OOBE
 - Play sound on each boot
 - Play sound on each boot and sign-out
?
This sound was specifically added for accessibility reasons. It should only be played during OOBE, never during sign-out or boot.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4985f62e4d57c66488206543fa01c020a81a0ed4

commit 4985f62e4d57c66488206543fa01c020a81a0ed4
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Sep 16 01:42:10 2017

Chrome OS: startup sound should only be played during OOBE.


Bug:  764351 
Change-Id: I0f033d7f246aebc4a2bddfffeb97ab9d3fbb9b22
Reviewed-on: https://chromium-review.googlesource.com/668128
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502468}
[modify] https://crrev.com/4985f62e4d57c66488206543fa01c020a81a0ed4/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/4985f62e4d57c66488206543fa01c020a81a0ed4/chrome/browser/chromeos/login/ui/login_display_host_impl.h

Labels: Merge-Request-62
Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 17 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 22 2017

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 25 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 25 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bccf77e6fe38aa478bf2cd7bd3164e29e49e422

commit 9bccf77e6fe38aa478bf2cd7bd3164e29e49e422
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Sep 25 15:32:11 2017

Chrome OS: startup sound should only be played during OOBE.

TBR=alemate@chromium.org

(cherry picked from commit 4985f62e4d57c66488206543fa01c020a81a0ed4)

Bug:  764351 
Change-Id: I0f033d7f246aebc4a2bddfffeb97ab9d3fbb9b22
Reviewed-on: https://chromium-review.googlesource.com/668128
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502468}
Reviewed-on: https://chromium-review.googlesource.com/682060
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#426}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/9bccf77e6fe38aa478bf2cd7bd3164e29e49e422/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/9bccf77e6fe38aa478bf2cd7bd3164e29e49e422/chrome/browser/chromeos/login/ui/login_display_host_impl.h

Sign in to add a comment