KeyboardTest.OnKeyboardTypeChanged Fails on CrOS |
|||||
Issue descriptionTest started failing consistently on CrOS. Disabling and assigning for now since it's blocking other CLs. https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 builds 44413 to 44431. Log: [ RUN ] KeyboardTest.OnKeyboardTypeChanged unknown file: Failure Unexpected mock function call - returning directly. Function call: OnKeyboardTypeChanged(false) Google Mock tried the following 1 expectation, but it didn't match: ../../components/exo/keyboard_unittest.cc:246: EXPECT_CALL(configuration_delegate, OnKeyboardTypeChanged(true))... Expected arg #0: is equal to true Actual: false Expected: to be called once Actual: never called - unsatisfied and active ../../components/exo/keyboard_unittest.cc:246: Failure Actual function call count doesn't match EXPECT_CALL(configuration_delegate, OnKeyboardTypeChanged(true))... Expected: to be called once Actual: never called - unsatisfied and active ../../components/exo/keyboard_unittest.cc:252: Failure Actual function call count doesn't match EXPECT_CALL(configuration_delegate, OnKeyboardTypeChanged(false))... Expected: to be called once Actual: never called - unsatisfied and active ../../components/exo/keyboard_unittest.cc:257: Failure Actual function call count doesn't match EXPECT_CALL(configuration_delegate, OnKeyboardTypeChanged(true))... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] KeyboardTest.OnKeyboardTypeChanged (39 ms)
,
Sep 12 2017
DeviceDataManager is shared across tests. just fyi.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/656a66bb3057b84a4a3452649adab061973bea1b commit 656a66bb3057b84a4a3452649adab061973bea1b Author: sebsg <sebsg@chromium.org> Date: Tue Sep 12 16:28:11 2017 Disable OnKeyboardTypeChanged on CrOS. Bug: 764338 Tbr: oshima@chromium.org, reveman@chromium.org Change-Id: I8057386a40ee245786bd4a424e9f456aeee87673 Reviewed-on: https://chromium-review.googlesource.com/663560 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501301} [modify] https://crrev.com/656a66bb3057b84a4a3452649adab061973bea1b/components/exo/keyboard_unittest.cc
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a684b16fbd66562c8542500c379380e221e47bf commit 0a684b16fbd66562c8542500c379380e221e47bf Author: Yuichiro Hanada <yhanada@chromium.org> Date: Thu Sep 14 01:42:10 2017 Re-enable KeyboardTest.OnKeyboardTypeChanged test. It assumed that DeviceDataManager has one external keyboard, but it cannot. I fixed the test to make sure that DeviceDataManager has one external keyboard at beginning of the test. Bug: 764338 Test: Run the test locally. Change-Id: Iba6ad7060d8322048ccabdf2dc19061e7a5c1fb2 Reviewed-on: https://chromium-review.googlesource.com/666097 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501834} [modify] https://crrev.com/0a684b16fbd66562c8542500c379380e221e47bf/components/exo/keyboard_unittest.cc
,
Sep 15 2017
It seems to be fixed. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=exo_unittests&tests=KeyboardTest.OnKeyboardTypeChanged
,
Jan 22 2018
,
Jan 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 12 2017