Under MD mode, the (?) button isn't positioned correctly in certain Content Settings bubbles |
|||||
Issue descriptionOS: Windows, Mac, Linux, Chrome 1. Browse to https://mixed-script.badssl.com/ 2. Open Mixed-content popup bubble Expected: (?) should be against the left margin according to the mocks: https://drive.google.com/open?id=0BxMIIGI80eU-cm8yREhWVDFrV3c Actual: (?) button is shifted to the right away from the left margin. It appears that the button is being sized to a standard MD size.
,
Sep 12 2017
,
Sep 12 2017
,
Sep 12 2017
,
Sep 14 2017
The actual issue here is that under MD mode, the grid layout column sizes on the button row are being linked. The code in dialog_client_view.cc is explicitly checking if the |extra_view_| is a button (and not a checkbox). Otherwise it skips linking that column.
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9cca689d4b5e6e8786948596ece07b76b30d67 commit be9cca689d4b5e6e8786948596ece07b76b30d67 Author: Allen Bauer <kylixrd@chromium.org> Date: Mon Sep 18 15:43:10 2017 Make sure the (?) button on content bubbles are aligned to the left margin. Bug: 764318 Change-Id: Ic865e011ea14a135ac92637fecd08fcab77bbdfb Reviewed-on: https://chromium-review.googlesource.com/667757 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#502583} [modify] https://crrev.com/be9cca689d4b5e6e8786948596ece07b76b30d67/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/be9cca689d4b5e6e8786948596ece07b76b30d67/ui/views/window/dialog_client_view_unittest.cc
,
Sep 18 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kylixrd@chromium.org
, Sep 12 2017