[Dice] Do not change account ordering |
||
Issue descriptionAccounts are currently not ordered in Chrome. However it is important that the order of accounts in the Gaia cookie does not change, as it has an impact on URLs on Google properties. Since the Gaia cookie is rebuilt by Chrome from the tokens, the tokens must be ordered by Chrome.
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ff5b4f575e798b3fd981264dd1596fc72b5de86 commit 3ff5b4f575e798b3fd981264dd1596fc72b5de86 Author: David Roger <droger@chromium.org> Date: Tue Sep 19 10:39:40 2017 [Signin] AccountReconcilor caches the first account When a reconcile is done, the first account is kept in memory. Then later, if the first account is missing (i.e. the user is not signed in, and the Gaia cookie is lost), the cached first account is reused if possible (i.e. if the token is still there). The main (only) practical use case for this behavior is when the user manually clears the Gaia cookies from the Chrome settings. When this happens, Dice will rebuild the Gaia cookie, and this CL ensures that the default Google account will be the same as before the cookie clear. Bug: 764303 Change-Id: I62f31527a4d5235362ad0d48c0fc6ab7b4d72571 Reviewed-on: https://chromium-review.googlesource.com/666621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#502819} [modify] https://crrev.com/3ff5b4f575e798b3fd981264dd1596fc72b5de86/chrome/browser/signin/account_reconcilor_unittest.cc [modify] https://crrev.com/3ff5b4f575e798b3fd981264dd1596fc72b5de86/components/signin/core/browser/account_reconcilor.cc [modify] https://crrev.com/3ff5b4f575e798b3fd981264dd1596fc72b5de86/components/signin/core/browser/account_reconcilor.h
,
Sep 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by droger@chromium.org
, Sep 12 2017