New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764291 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Add unit tests for device enumeration functionality of AudioManagerCras

Project Member Reported by maxmorin@chromium.org, Sep 12 2017

Issue description

The dependency on hardware devices could be eliminated by using a fake CrasAudioClient (like in CrasAudioHandlerTest https://cs.chromium.org/chromium/src/chromeos/audio/cras_audio_handler_unittest.cc). Tests would catch regressions like  issue 764228 . Wu-cheng pointed out that none of the CQ bots could run such a test, since none use CrAS (there is a Chrome OS-on-Linux bot, but it's using either AudioManagerAlsa or AudioManagerPulse). A real Chrome OS bot would thus also be needed.
 

Comment 1 by warx@chromium.org, Sep 13 2017

Cc: -warx@chromium.org dgreid@chromium.org
Owner: warx@chromium.org
Status: Assigned (was: Available)
I will take a look here.

Comment 2 by warx@chromium.org, Jun 20 2018

Owner: ----
Status: Untriaged (was: Assigned)
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
This seems old, is it something we still need?
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment