New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764260 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
hnakashima@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 768520



Sign in to add a comment

Hook up "undo" and "redo" context menu item in interactive PDF forms

Reported by vku...@etouch.net, Sep 12 2017 
Chrome Version:62.0.3202.18 (Official Build)7ba42bf8da38fd2a88b71bea05df3ebfd29ee96c-refs/branch-heads/3202@{#152} (32/64-bit) 
OS:Windows (7,8,8.1,10),Linux (14.04 LTS,Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf
(2)Enter any text for e.g 'test' in name field or any field
(3)Now right on it and observe the context menu options

Actual: Context menu option like 'select all' and 'undo' etc remains disabled after entering text in any field.

Expected: Context menu option like 'select all' and 'undo' etc should be enabled once any text is entered.

This is a Non-regression issue seen from 'M62' series i.e 62.0.3183.0 since proper context menu appears from this build.
Actual_pdf.mp4
318 KB View Download

Comment 1 by rbasuvula@chromium.org, Sep 12 2017

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by thestig@chromium.org, Sep 12 2017

Labels: -Pri-2 -M-63 OS-Chrome Pri-3
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Summary: Hook up "undo" and "redo" context menu item in interactive PDF forms (was: Context menu option like 'select all' and 'undo' etc remains disabled after entering text in any field.)
This is a known issue. I filed  bug 753216  for select all already. I guess this one can be undo/redo.

Comment 3 by dsinclair@chromium.org, Sep 18 2017

Cc: hnakashima@chromium.org

Comment 4 by hnakashima@chromium.org, Oct 16 2017

Blocking: 768520

Comment 5 by thestig@chromium.org, Apr 17 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/ee96772e0878fa385b9a4a736a2fc109e19fd01e

commit ee96772e0878fa385b9a4a736a2fc109e19fd01e
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Apr 19 20:55:54 2018

Add public APIs for undo / redo in forms.

Add FORM_CanUndo(), FORM_CanRedo(), FORM_Undo(), and FORM_Redo().

BUG= chromium:764260 

Change-Id: I1d9ea67152d9b35d9b8e1d7ef7d019706fdfa30a
Reviewed-on: https://pdfium-review.googlesource.com/30872
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_annothandlermgr.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/xfa/fxfa/cxfa_ffwidgethandler.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_combo_box.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_widgethandler.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/fpdf_view_c_api_test.c
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_combo_box.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_pageview.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/formfiller/cffl_interactiveformfiller.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_wnd.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_baannothandler.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/fpdf_formfill.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/xfa/fxfa/cxfa_ffwidgethandler.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_annothandlermgr.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/fpdf_formfill_embeddertest.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_baannothandler.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/public/fpdf_formfill.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_widgethandler.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_wnd.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_xfawidgethandler.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/ipdfsdk_annothandler.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/formfiller/cffl_formfiller.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/formfiller/cffl_formfiller.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_edit_ctrl.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/pwl/cpwl_edit_ctrl.cpp
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_pageview.h
[modify] https://crrev.com/ee96772e0878fa385b9a4a736a2fc109e19fd01e/fpdfsdk/cpdfsdk_xfawidgethandler.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35fa35716150a4a7a222979e36b6f45e523e68c2

commit 35fa35716150a4a7a222979e36b6f45e523e68c2
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 20 00:42:15 2018

Roll src/third_party/pdfium/ 9914d4dc1..901f34332 (6 commits)

https://pdfium.googlesource.com/pdfium.git/+log/9914d4dc1e7a..901f34332823

$ git log 9914d4dc1..901f34332 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 hnakashima Caret moves after clicked char if closer to its right rect boundary.
2018-04-19 hnakashima Fix duplicated text in each line in XFA widgets.
2018-04-19 hnakashima Fix caret moving to start of edit on click after the text.
2018-04-19 thestig Add public APIs for undo / redo in forms.
2018-04-19 thestig Change SHADING_STEPS from a #define to a constant.
2018-04-19 hnakashima Fix caret not moving to click target in XFA edit.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:832293 , chromium:832909 , chromium:832293 , chromium:764260 , chromium:832293 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0c49fb5b7d6ee39f132bf4c8e2daf7a9740e5c39
Reviewed-on: https://chromium-review.googlesource.com/1019973
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552220}
[modify] https://crrev.com/35fa35716150a4a7a222979e36b6f45e523e68c2/DEPS
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cff6f0d83a1b5ae0449688ea844cf5cb7546005

commit 9cff6f0d83a1b5ae0449688ea844cf5cb7546005
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Apr 20 02:35:32 2018

Hook up Undo / Redo context menu items in interactive PDF forms.

This follows a similar strategy as the CLs for  https://crbug.com/753216 .

BUG= 764260 

Change-Id: I52523799a8e1f749cd2f7acefe5a287c6144cb57
Reviewed-on: https://chromium-review.googlesource.com/1015891
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552237}
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/public/renderer/pepper_plugin_instance.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/fake_pepper_plugin_instance.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/fake_pepper_plugin_instance.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/content/renderer/pepper/pepper_webplugin_impl.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/pdf/out_of_process_instance.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/pdf/out_of_process_instance.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/pdf/pdf_engine.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/pdf/pdfium/pdfium_engine.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/ppapi/c/private/ppp_pdf.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/ppapi/proxy/ppp_pdf_proxy.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/ppapi/proxy/ppp_pdf_proxy.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/third_party/blink/public/web/web_plugin.h
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/9cff6f0d83a1b5ae0449688ea844cf5cb7546005/third_party/blink/renderer/core/page/context_menu_controller.cc

Comment 9 by thestig@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

Comment 10 by vku...@etouch.net, Apr 23 2018 

Update:

Rechecked above issue on latest canary version #68.0.3404.0(Official build) and unable to verify issue on Mac(10.12.6,10.13.1,10.13.5) OS due to issue ID 835786 But its working fine on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS.
►

Sign in to add a comment