New issue
Advanced search Search tips

Issue 764249 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 761305



Sign in to add a comment

Media Controls Redesign: Add local style element

Project Member Reported by beccahughes@chromium.org, Sep 12 2017 
The media controls are currently using a shadow DOM and styled using the UA mediaControls.css stylesheet. This means that we cannot use CSS animations from the UA stylesheet which is an important part of the new media controls.

Therefore the plan is to add a <style> element in the shadow dom.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72fb696794b15424f31ab7782b020c8f3a992c6c

commit 72fb696794b15424f31ab7782b020c8f3a992c6c
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Sep 15 12:59:26 2017

Media Controls: Disable DCHECK in StyleResolver for media controls.

There is an assumption in StyleResolver that UA shadow trees
don't have a <style> element. This adds an exception if the element
has a parent element that is part of the media controls.

BUG= 764249 

Change-Id: I1be90464bae66a4753efda432c07024caeeb1b6d
Reviewed-on: https://chromium-review.googlesource.com/663137
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502231}
[modify] https://crrev.com/72fb696794b15424f31ab7782b020c8f3a992c6c/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/72fb696794b15424f31ab7782b020c8f3a992c6c/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/72fb696794b15424f31ab7782b020c8f3a992c6c/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/72fb696794b15424f31ab7782b020c8f3a992c6c/third_party/WebKit/Source/core/dom/NodeTest.cpp

Comment 2 by beccahughes@chromium.org, Nov 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment