New issue
Advanced search Search tips

Issue 764242 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Tests] : NOTREACHED in chrome_pdf::DocumentLoader::DidOpen

Project Member Reported by rbasuvula@chromium.org, Sep 12 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
========
https://chromium.googlesource.com/chromium/src.git/+/24428257e9aa3f0effbed3011ecb8a71bbe40b39

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=761380

Thank you!
 
Status: Started (was: Assigned)
Status: WontFix (was: Started)
I have taken a look at how much effort this would be. This class and most of the code in this directory are currently not directly tested via unit tests. Since the method in question is not exposed in the public API, testing this code path explicitly would involve mocking out how data requests are handled via PP::URLLoader, which is a relatively large amount of engineering work.

The specific change in this CL was removing an instance of NOTREACHED, which should have been removed when handling for the case was added. I don't reasonably expect there to be a regression of this behaviour.

At this time I don't think it is worth the effort to put in a test for just this issue due to the complexity involve and low value.

Sign in to add a comment