New issue
Advanced search Search tips

Issue 764227 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

BufferTest.ReleaseCallback exo_unittest is flaky

Project Member Reported by benwells@chromium.org, Sep 12 2017

Issue description

It's failed three times on this bot:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29

Builds 44397, 44412, 44413.

Sample output:
[ RUN      ] BufferTest.ReleaseCallback
../../components/exo/buffer_unittest.cc:66: Failure
      Expected: release_call_count
      Which is: 0
To be equal to: 1
[  FAILED  ] BufferTest.ReleaseCallback (86 ms)
 
Cc: reve...@chromium.org
Owner: osh...@chromium.org
We haven't seen any of these failures in the past. I suspect that it's related to https://chromium.googlesource.com/chromium/src/+/245abec2af859afa90211b644c6a98326db33314 and would prefer if the reverted that until we understand why it's causing this test to be flaky instead of disabling the test.
Cc: -reve...@chromium.org penghuang@chromium.org osh...@chromium.org
Labels: -Pri-3 M-63 OS-Chrome Pri-2
Owner: reve...@chromium.org
Status: Available (was: Untriaged)
We should figure out why this is being flaky asap as it might be a real issue.

Comment 3 by osh...@chromium.org, Sep 12 2017

It will retry failed tests by running them sequentially. If it've been causing it, one possibility was that some tests were order dependent. (I've seen such case in the past)
Owner: osh...@chromium.org
Some confusion as KeyboardTest.OnKeyboardTypeChanged was also failing but it seems like not running the tests in parallel made ReleaseCallback not falky anuymore. oshima@, can you take a look at this?

Comment 5 by osh...@chromium.org, Sep 12 2017

I couldn't repro this failure locally, although I've seen the crash below (although it's very rare)

* component build
* debug = false
* dcheck_always_on = true
* command line: --brave-new-test-launcher --test-launcher-bot-mode   --cfi-diag=0 --test-launcher-jobs=4

reveman@, how did you run your test?

[ RUN      ] SurfaceTest.SetOpaqueRegion/1
[38818:38818:0912/093809.383075:2831743693381:FATAL:test_gpu_memory_buffer_manager.cc(154)] Check failed: buffers_.find(gpu_memory_buffer_id.id) != buffers_.end(). 
#0 0x7f533a87938c base::debug::StackTrace::StackTrace()
#1 0x7f533a89ef3c logging::LogMessage::~LogMessage()
#2 0x0000005aa933 viz::TestGpuMemoryBufferManager::OnGpuMemoryBufferDestroyed()
#3 0x0000005aaca0 viz::(anonymous namespace)::GpuMemoryBufferImpl::~GpuMemoryBufferImpl()
#4 0x0000004d3fc6 exo::Buffer::~Buffer()
#5 0x0000004a64fe exo::(anonymous namespace)::SurfaceTest_SetOpaqueRegion_Test::TestBody()
#6 0x000000504896 testing::Test::Run()
#7 0x000000505230 testing::TestInfo::Run()
#8 0x000000505717 testing::TestCase::Run()
#9 0x00000050bb77 testing::internal::UnitTestImpl::RunAllTests()
#10 0x00000050b7f7 testing::UnitTest::Run()
#11 0x00000053cd42 base::TestSuite::Run()
#12 0x00000053e08b base::LaunchUnitTests()
#13 0x00000044cfb4 main
#14 0x7f5336e5ef45 __libc_start_main
#15 0x00000044bea0 <unknown>


Status: Assigned (was: Available)
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Sign in to add a comment