New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764217 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: glGetError() == GL_NO_ERROR in feature_info.cc

Project Member Reported by ClusterFuzz, Sep 12 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5707399980908544

Fuzzer: libFuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  glGetError() == GL_NO_ERROR in feature_info.cc
  base::debug::DebugBreak
  gpu::gles2::IsGL_REDSupportedOnFBOs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=500987:501057

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5707399980908544

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org kkaluri@chromium.org
Components: Internals>GPU
Labels: Test-Predator-Wrong-CLs M-63
Owner: cwallez@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possibl suspects.
Using Code Search for the file, "feature_info.cc" assigning to the concern owner who might be related or worked on similar file.

Suspected CL: https://chromium.googlesource.com/chromium/src/+/1564bf9bb8519b94e4cd09f00f6fff5369ac899b

cwallez@ -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
That CL is unlikely to be the culprit, but it should be easy to reproduce the CHECK. I'll look into it.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f61dcd9971c25cb70fe292278957f353be4455

commit d4f61dcd9971c25cb70fe292278957f353be4455
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Sep 13 22:10:52 2017

sampler_manager: Fix Parameterf -> Parameteri conversion

The OpenGL ES spec says that float parameters should be round to
integers. SetSamplerParameterf was using static_cast that floors the
float value.

This makes Sampler's behavior the same as Texture's that is rounding
too.

BUG= 764217 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1475f30b4ed1d6f64292b7f3532eaf2bd92682b
Reviewed-on: https://chromium-review.googlesource.com/665169
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501769}
[modify] https://crrev.com/d4f61dcd9971c25cb70fe292278957f353be4455/gpu/command_buffer/service/sampler_manager.cc

Project Member

Comment 4 by ClusterFuzz, Sep 14 2017

ClusterFuzz has detected this issue as fixed in range 501735:501797.

Detailed report: https://clusterfuzz.com/testcase?key=5707399980908544

Fuzzer: libFuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  glGetError() == GL_NO_ERROR in feature_info.cc
  base::debug::DebugBreak
  gpu::gles2::IsGL_REDSupportedOnFBOs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=500987:501057
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=501735:501797

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5707399980908544

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Sep 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5707399980908544 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment