New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764195 link

Starred by 1 user
Status: Fixed
Owner:
dcheng@chromium.org
Closed: Sep 2017
Cc:
█ maxbogue@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Get rid of location_string_ in components/sync/syncable/write_transaction_info.h

Project Member Reported by dcheng@chromium.org, Sep 12 2017 
  // If tracked_objects::Location becomes assignable, we can use that
  // instead.

Location is assignable, so this should probably just assign a location object now.

(+maxbogue who was the unfortunate one to touch this line most recently, but I traced this back for fun, and this comment dates from https://codereview.chromium.org/7926001)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42fe2cee1e9acd92ea437d859dc6dcdfde2710f9

commit 42fe2cee1e9acd92ea437d859dc6dcdfde2710f9
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Sep 12 23:42:05 2017

Store a base::Location in syncer::syncable::WriteTransactionInfo

This class used to hold the location as a string, since base::Location
wasn't assignable. It is now.

Bug:  764195 
Change-Id: I81a04d2ecc981c39f0e0bcb54cb76e6ee87248f8
Reviewed-on: https://chromium-review.googlesource.com/664220
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501455}
[modify] https://crrev.com/42fe2cee1e9acd92ea437d859dc6dcdfde2710f9/components/sync/syncable/write_transaction_info.cc
[modify] https://crrev.com/42fe2cee1e9acd92ea437d859dc6dcdfde2710f9/components/sync/syncable/write_transaction_info.h

Comment 2 by dcheng@chromium.org, Sep 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment