New issue
Advanced search Search tips

Issue 764184 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

IDL parser: IDL parser should use None for indentifier of unnamed operations

Project Member Reported by peria@chromium.org, Sep 12 2017

Issue description

Now IDL parser uses '_unnamed_' as identifier of unnamed operations in Web IDL,
while '_unnamed_' can be a valid identifier in spec.

So let's remove this alias and use None or '' instead.
 
I am working on this issue. Patch submitted : https://chromium-review.googlesource.com/c/chromium/src/+/685114
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/201c7ba63cdee933b58dbe53b962b10b2637d25f

commit 201c7ba63cdee933b58dbe53b962b10b2637d25f
Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Date: Wed Sep 27 13:25:00 2017

IDL parser: IDL parser should use None for indentifier of unnamed operations

IDL parser uses '_unnamed_' as identifier of unnamed operations
in Web IDL, while '_unnamed_' can be a valid identifier in spec.
So replacing '_unnamed_' identifier with empty string.

Bug:  764184 
Change-Id: Idfcde792d8665932d15dcae1ae65f2c66a247025
Reviewed-on: https://chromium-review.googlesource.com/685114
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504644}
[modify] https://crrev.com/201c7ba63cdee933b58dbe53b962b10b2637d25f/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
[modify] https://crrev.com/201c7ba63cdee933b58dbe53b962b10b2637d25f/tools/idl_parser/idl_parser.py
[modify] https://crrev.com/201c7ba63cdee933b58dbe53b962b10b2637d25f/tools/idl_parser/test_parser/interface_web.idl

Status: Fixed (was: Available)

Sign in to add a comment