Issue metadata
Sign in to add a comment
|
Support request body in ServiceWorkerURLLoaderJob |
||||||||||||||||||||||
Issue descriptionCurrently there's a TODO in ServiceWorkerLoaderHelpers::CreateFetchRequest. // TODO(kinuko): Implement request.request_body handling. DCHECK(!request.request_body); We should handle the case where request.request_body exists. You can use ServiceWorkerURLRequestJob as a guide for this. I think we can just assume features::IsMojoBlobsEnabled() is on for this, and don't worry about handling the request body when that feature is disabled. I *think* that means we don't need to do the "FileSizeResolver" work that ServiceWorkerURLLoaderJob does (I assume ServiceWorkerFetchRequest::blob_uuid and blob_size are not relevant for MojoBlobs). For now, also let's just get it working for ServiceWorkerURLLoaderJob, then work on ServiceWorkerSubresourceLoader later.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c5f70e39037a77e9279f777c01b99afbe9b766d commit 1c5f70e39037a77e9279f777c01b99afbe9b766d Author: Emi Morikawa <emim@google.com> Date: Tue Sep 26 11:55:19 2017 Implement request body in ServiceWorkerURLLoaderJob and add test This CL implements blob request body for bypassing to a service worker. When a request body exists, SWURLLoaderJob creates BlobHandle to forward a request to the service worker. Bug: 764154 Change-Id: Ie432db242b643443b161a4c8ea8adbbc08169e15 Reviewed-on: https://chromium-review.googlesource.com/672103 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#504343} [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/browser/service_worker/service_worker_url_loader_job.cc [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/browser/service_worker/service_worker_url_loader_job.h [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/browser/service_worker/service_worker_url_loader_job_unittest.cc [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/child/service_worker/service_worker_subresource_loader.cc [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/child/service_worker/service_worker_subresource_loader_unittest.cc [modify] https://crrev.com/1c5f70e39037a77e9279f777c01b99afbe9b766d/content/common/service_worker/service_worker_loader_helpers.cc
,
Sep 29 2017
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by emim@google.com
, Sep 12 2017