New issue
Advanced search Search tips

Issue 764138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

remove "LUCI " builder name prefix

Project Member Reported by no...@chromium.org, Sep 12 2017

Issue description

Currently builders running on LUCI have "LUCI " prefix in their names, compared
to their counterparts on Buildbot. This slightly complicates other things.
It is simpler if builder names match on Buildbot and LUCI.

Remove "LUCI " builder name prefix. Make LUCI builder names match Buildbot builder names.

This blocks LUCI Beta launch.
 

Comment 1 by no...@chromium.org, Sep 12 2017

the "LUCI chip" was implemented in gerrit-buildbucket plugin https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/660602

Comment 2 by no...@chromium.org, Sep 12 2017

kitchen: do not require "LUCI " prefix in builder names https://chromium-review.googlesource.com/#/c/661792/

Comment 3 by no...@chromium.org, Sep 12 2017

Components: -Infra>Platform Infra>Platform>Buildbucket>Swarmbucket

Comment 4 by no...@chromium.org, Sep 13 2017

this is currently blocked on gerrit-buildbucket rollout. It is planned on this Thu
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ff087f9f3db63daa15d42053d156f1da01f5fe3a

commit ff087f9f3db63daa15d42053d156f1da01f5fe3a
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 13 19:22:38 2017

[luci-migration] Deprecate "LUCI " builder prefix

Currently builders running on LUCI have "LUCI " prefix in their names, compared
to their counterparts on Buildbot. This slightly complicates other things.
It is simpler if builder names match on Buildbot and LUCI.

Deprecate the "LUCI " builder name prefix, but make the analysis code
search in both old and new builder names for a week.

See also
https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/660602

R=tandrii@chromium.org

Bug:  764138 
Change-Id: Iad471c6dae7ed1ebbf594fc8888928a44a3b7cd3
Reviewed-on: https://chromium-review.googlesource.com/661720
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/discovery/discovery_test.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/scheduling/scheduling_test.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/app/templates/pages/builder.html
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/bugs/description_test.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/app/analysis.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/bugs/description.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/analysis/tryjobs.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/analysis/tryjobs_test.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/storage/builder.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/scheduling/scheduling.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/discovery/discovery.go
[modify] https://crrev.com/ff087f9f3db63daa15d42053d156f1da01f5fe3a/go/src/infra/appengine/luci-migration/scheduling/scheduling.infra_testing

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e345c8ccccd935552f9d58c0a64beeb88dcc320d

commit e345c8ccccd935552f9d58c0a64beeb88dcc320d
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 13 22:10:19 2017

Comment 7 by no...@chromium.org, Sep 13 2017

the prefix is a part of the named cache key, so removing invalidates cache. This will cause first build per builder per machine to be unusually slow and will probably make luci-migration think the builder is not WAI. It will get resolved in a few days.

Anyway, we are still waiting for gerrit rollout.

Comment 8 by no...@chromium.org, Sep 13 2017

Cc: efoo@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/248ebfcd32b0595f1a6b27bdf44a2476dd57154d

commit 248ebfcd32b0595f1a6b27bdf44a2476dd57154d
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 14 06:52:45 2017

[luci-migration] do not retry prefixed builds

Do not retry residue prefixed builds.
Prefixed builders were undefined.

TBR=tandrii@chromium.org
Bug:  764138 
Change-Id: Ibcba37b1482be90523a584e62872e4ef558020b8
Reviewed-on: https://chromium-review.googlesource.com/666149
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/248ebfcd32b0595f1a6b27bdf44a2476dd57154d/go/src/infra/appengine/luci-migration/scheduling/scheduling.go

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00e8b61cd4d25283683b1c010b6911d826a874a

commit f00e8b61cd4d25283683b1c010b6911d826a874a
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 14 19:46:58 2017

cq.cfg: remove "LUCI " builder prefix

Remove the prefix from the LUCI builders.

R=estaab@chromium.org, dpranke@chromium.org

Bug:  764138 
Change-Id: I92ac5937b3892a89521dc5cf5a6d9c1188eaeb08
Reviewed-on: https://chromium-review.googlesource.com/662278
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502020}
[modify] https://crrev.com/f00e8b61cd4d25283683b1c010b6911d826a874a/infra/config/cq.cfg

Comment 11 by no...@chromium.org, Sep 21 2017

Status: Fixed (was: Started)

Sign in to add a comment