New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764125 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

MD Extensions: accessibility audit

Project Member Reported by scottchen@chromium.org, Sep 11 2017

Issue description

We should implement the accessibility testing framework from settings, and make a list of accessibility bugs.
 
Blocking: 769402
Owner: hcarmona@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d1a06bdd1429338d2f25900ee78c2361411ced

commit 49d1a06bdd1429338d2f25900ee78c2361411ced
Author: dpapad <dpapad@chromium.org>
Date: Fri Oct 06 18:43:19 2017

WebUI: Disable obsolete a11y checks in Settings and MD extensions.

 - Changing the default behavior of PolymerTest class to skip the
   obsolete a11y checks.
 - Disabling those checks in Settings and MD Extensions.
 - Preserving the previous behavior (enabled/disabled) for all other
   pages.

Bug:  764125 
Change-Id: I17899d075c2dc246838fdbb39b6f55b7e3ece46a
Reviewed-on: https://chromium-review.googlesource.com/704186
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507128}
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/md_downloads/downloads_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/polymer_browser_test_base.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/polymer_interactive_ui_test.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/49d1a06bdd1429338d2f25900ee78c2361411ced/chrome/test/data/webui/settings/settings_page_browsertest.js

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ffff42587bb6d8b28d7fe91cb8d1258de3a5007

commit 0ffff42587bb6d8b28d7fe91cb8d1258de3a5007
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Oct 09 21:36:36 2017

WebUI: Add aria landmark roles to MD Extensions page.

This is in preparation of enabling automated a11y audit.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iff4ffa16c772420e20e5f0543f072d8f653e62f3
Reviewed-on: https://chromium-review.googlesource.com/705931
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507497}
[modify] https://crrev.com/0ffff42587bb6d8b28d7fe91cb8d1258de3a5007/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/0ffff42587bb6d8b28d7fe91cb8d1258de3a5007/chrome/browser/resources/md_extensions/sidebar.js
[modify] https://crrev.com/0ffff42587bb6d8b28d7fe91cb8d1258de3a5007/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/0ffff42587bb6d8b28d7fe91cb8d1258de3a5007/chrome/browser/resources/md_extensions/toolbar.js

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe9ece000a99c31721bd1af850f818c16c286af

commit dbe9ece000a99c31721bd1af850f818c16c286af
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Oct 11 20:40:12 2017

WebUI: Add missing labels to MD Extensions buttons.

This is in preparation of enabling automated a11y audit.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5062af4e94e3057fb9ad8d0be2aa4e823c800a71
Reviewed-on: https://chromium-review.googlesource.com/706310
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508098}
[modify] https://crrev.com/dbe9ece000a99c31721bd1af850f818c16c286af/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/dbe9ece000a99c31721bd1af850f818c16c286af/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/dbe9ece000a99c31721bd1af850f818c16c286af/chrome/browser/ui/webui/extensions/extensions_ui.cc

Comment 8 by groby@google.com, Oct 25 2017

Any update on the automated audit?
Audit is added here: https://crrev.com/c/707304. CL is ready to land, bot flaked should land as soon as bot is green. Currently adding more robust checks since that CL enables the audit w/o any mock data.
Ran quick audit manually with chromevox on chromeos, found these issues:

Side nav reports "Menu with 0 items" with chromevox
Debug button "Update" doesn't provide context for a11y
Extension image unlabeled
Extension enabled button unlabeled
Details: back button unlabeled
Details: extension image unlabeled
Details: "On" Toggle unlabeled
Details: Allow in incognito button not focusable w/ chromevox
Details: Collect errors toggle button not focusable w/ chromevox
Details: Extension options button unlabeled
Details: Remove extension button double labeled
Details: "source" label ambiguous
Image overlay warning not read by a11y tools
Developer mode toggle "pressed/unpressed" should be "enabled/disabled", same for extension enabled button

Comment 12 by groby@google.com, Oct 27 2017

Unless these are all quick fixes, please file bugs and mark them as blockers for this.
Blockedon: 779264 779270 779274 779268 779269
Update on the issues above w/ issues for more involved fixes as well as CLs for easier ones.

Side nav reports "Menu with 0 items" with chromevox - No longer reproducible

Debug button "Update" doesn't provide context for a11y -  Issue 779264 

Extension image unlabeled - https://crrev.com/c/738635
Details: extension image unlabeled (labelled by above CL)

Extension enabled button unlabeled - https://crrev.com/c/739956

Details: "On" Toggle unlabeled - https://crrev.com/c/740823

Details: back button unlabeled - https://crrev.com/c/742144
Details: Extension options button unlabeled (labelled by above CL)

Details: Allow in incognito button not focusable w/ chromevox -  Issue 779268 
Details: Collect errors toggle button not focusable w/ chromevox (bug covers both toggles)

Details: Remove extension button double labeled -  Issue 779269 

Details: "source" label ambiguous -  Issue 779270 

Image overlay warning not read by a11y tools -  Issue 779274 

Developer mode toggle "pressed/unpressed" should be "enabled/disabled", same for extension enabled button - Won't fix: 'enabled/disabled' could be confusing for a control that itself can be enabled/disabled. This is to avoid getting into a state where we read the toggle is 'enabled, disabled' because the extension is enabled but cannot be disabled so we've disabled the toggle... let's avoid this.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/507133a391056c203916c62dbde64694df550e0e

commit 507133a391056c203916c62dbde64694df550e0e
Author: Hector Carmona <hcarmona@chromium.org>
Date: Sat Oct 28 00:09:18 2017

MD Extensions A11y: Label extension/app enabled toggle.

Also creates ItemBehavior that will be used in other places we need
app vs extension labels.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic59f3861c8dc362f338cc2b00fea6d85ce16d7be
Reviewed-on: https://chromium-review.googlesource.com/739956
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512361}
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/extensions_resources.grd
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/item.js
[add] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/item_behavior.html
[add] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/resources/md_extensions/item_behavior.js
[modify] https://crrev.com/507133a391056c203916c62dbde64694df550e0e/chrome/browser/ui/webui/extensions/extensions_ui.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c7690ba81dc2efb35bc145efa45d5051675b83

commit d1c7690ba81dc2efb35bc145efa45d5051675b83
Author: Hector Carmona <hcarmona@chromium.org>
Date: Sat Oct 28 17:06:52 2017

MD Extensions: Label all extension icons.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib37d34dc82f7ee8bcdc0e050fbc6e7d5c2993abb
Reviewed-on: https://chromium-review.googlesource.com/738635
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512403}
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/keyboard_shortcuts.js
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/kiosk_dialog.js
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/d1c7690ba81dc2efb35bc145efa45d5051675b83/chrome/browser/ui/webui/extensions/extensions_ui.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0626323cf994e41599a06975d26bb9e8524fcb28

commit 0626323cf994e41599a06975d26bb9e8524fcb28
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Oct 30 19:47:13 2017

MD Extension A11y: Label 'on' toggle in Extension Details.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If131619735e2e81b6d45837616b5a4e56ff6173f
Reviewed-on: https://chromium-review.googlesource.com/740823
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512584}
[modify] https://crrev.com/0626323cf994e41599a06975d26bb9e8524fcb28/chrome/browser/resources/md_extensions/detail_view.html

Blocking: -769402 780164
I am un-marking this issue as a Dev blocker, since it seems that there has been enough progress. The remaining known issues are already captured by bugs attached here, with the most severe one  issue 779268 .
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa42a993c8c016dc9388bf9323b56bf86384393c

commit fa42a993c8c016dc9388bf9323b56bf86384393c
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Nov 10 21:45:35 2017

MD Extensions A11y: Add label to several buttons that were missing it.

Bug:  764125 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98ccae665b0909edab862248fafb063703cf81f1
Reviewed-on: https://chromium-review.googlesource.com/742144
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515695}
[modify] https://crrev.com/fa42a993c8c016dc9388bf9323b56bf86384393c/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/fa42a993c8c016dc9388bf9323b56bf86384393c/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/fa42a993c8c016dc9388bf9323b56bf86384393c/chrome/browser/ui/webui/extensions/extensions_ui.cc

Blockedon: 784567
Blockedon: 784570
Blockedon: 788939
Blockedon: 788942
Blockedon: 788950
Status: Fixed (was: Started)
This was out meta bug for our own a11y testing, all issues found in it are fixed, so closing as "fixed"

Sign in to add a comment