New issue
Advanced search Search tips

Issue 764114 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Sep 2017
Cc:
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 403462



Sign in to add a comment

Register Clear Key CDM in CdmRegistry

Project Member Reported by xhw...@chromium.org, Sep 11 2017 
Previously when using pepper CDM, Clear Key CDM (adapter) was registered as a pepper plugin, using --register-pepper-plugins. As we are moving to use mojo CDM, this will not work.

We need a new mechanism to register the Clear Key CDM for testing purposes. Since we are not using pepper, we don't need to specify anything related to the adapter, the display name, or the mime type.

Note that we already have a feature to enable External Clear Key key system for testing (kExternalClearKeyForTesting). Clear Key CDM should only be registered when this feature is enabled. Or maybe we can combine that feature and the registration into one command line switch.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fef7061a8f643ce86a5751aed9e0515304cab224

commit fef7061a8f643ce86a5751aed9e0515304cab224
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Sep 14 02:41:12 2017

media: Register Clear Key CDM path in command line

Previously when using pepper CDM, Clear Key CDM (adapter) was registered
as a pepper plugin, using --register-pepper-plugins. As we are moving to
use mojo CDM, this will not work. This CL introduces a new command line
switch --clear-key-cdm-path-for-testing to specify the path to the CDM.
Since we are not using pepper, we don't need to specify anything related
to the adapter, the display name, or the mime type.

Note that key system support query is still using pepper plugin info. So
even for tests using mojo CDM, we still need to RegisterPepperCdm() for
now. We will fix this in a future CL.

BUG= 764114 
TEST=Existing tests work.

Change-Id: I246446eae690df275378afa32ccb7bef4b055dc2
Reviewed-on: https://chromium-review.googlesource.com/662280
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501848}
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/BUILD.gn
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
[rename] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/media/library_cdm_test_helper.cc
[rename] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/browser/media/library_cdm_test_helper.h
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/common/BUILD.gn
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/media/base/media_switches.cc
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/media/base/media_switches.h
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/media/cdm/cdm_paths.cc
[modify] https://crrev.com/fef7061a8f643ce86a5751aed9e0515304cab224/media/cdm/cdm_paths.h

Comment 2 by xhw...@chromium.org, Sep 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment