kernel: gnubby with hid firmware bug fixed in 2014 comes back after switching to usb_autopm_get_interface_no_resume |
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9592.71.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.80 Safari/537.36 Steps to reproduce the problem: See issue https://bugs.chromium.org/p/chromium/issues/detail?id=431886 Revert the change i landed in chromium tree, try to apply a change adapted by dtor to upstream, along with a suggestion from Oliver to use usb_autopm_get_interface_no_resume instead. What is the expected behavior? What went wrong? Gnubby stays in active state instead of suspended. Did this work before? N/A Chrome version: 60.0.3112.80 Channel: beta OS Version: 9592.71.0 Flash Version:
,
Sep 11 2017
,
Oct 16 2017
Dmitry, I think I saw you posted something to address this. Is this ready to be picked back and this fixed properly?
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/29870f3c4104e628c75e000b7b5974db78a42b0d commit 29870f3c4104e628c75e000b7b5974db78a42b0d Author: Dmitry Torokhov <dmitry.torokhov@gmail.com> Date: Tue Oct 17 07:33:13 2017 UPSTREAM: HID: hidraw: fix power sequence when closing device We should not try to bring HID device out of full power state before calling hid_hw_close(), so that transport driver operates on powered up device (making this inverse of the opening sequence). Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz> BUG= chromium:764112 TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=431886 (cherry picked from commit 814b6d17487fd970f293ee674c90ba267f82415d) Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Change-Id: I4130344b480e685e1d3fac48aa32289d61bf5bc7 Reviewed-on: https://chromium-review.googlesource.com/721807 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/29870f3c4104e628c75e000b7b5974db78a42b0d/drivers/hid/hidraw.c
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b93bd996d15c7403a4c896d57b3013bd05e0cc09 commit b93bd996d15c7403a4c896d57b3013bd05e0cc09 Author: Dmitry Torokhov <dtor@chromium.org> Date: Tue Oct 17 07:33:15 2017 Revert "CHROMIUM: HID: usbhid: get/put around clearing needs_remote_wakeup" This reverts commit d0b8047c47a35978f9181b8d22d6fc916817cb0b. Now that we have proper sequencing of power operations in hidraw, this change is no longer needed. BUG= chromium:764112 TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=431886 Change-Id: If2f54047fcd31d7e9c6594cb65cf11a3af4b52d9 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/721808 Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/b93bd996d15c7403a4c896d57b3013bd05e0cc09/drivers/hid/usbhid/hid-core.c
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/426fbabe5d864846ce49803cfff7a158d9daf8cc commit 426fbabe5d864846ce49803cfff7a158d9daf8cc Author: Dmitry Torokhov <dmitry.torokhov@gmail.com> Date: Thu Oct 19 19:56:45 2017 UPSTREAM: HID: hidraw: fix power sequence when closing device We should not try to bring HID device out of full power state before calling hid_hw_close(), so that transport driver operates on powered up device (making this inverse of the opening sequence). Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz> BUG= chromium:764112 TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=431886 (cherry picked from commit 814b6d17487fd970f293ee674c90ba267f82415d) Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Change-Id: I4130344b480e685e1d3fac48aa32289d61bf5bc7 Reviewed-on: https://chromium-review.googlesource.com/721807 Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit 29870f3c4104e628c75e000b7b5974db78a42b0d) Reviewed-on: https://chromium-review.googlesource.com/723646 Reviewed-by: Benson Leung <bleung@chromium.org> [modify] https://crrev.com/426fbabe5d864846ce49803cfff7a158d9daf8cc/drivers/hid/hidraw.c
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/296d003531f77b6d1c1bc2be5b560087be3dbc2c commit 296d003531f77b6d1c1bc2be5b560087be3dbc2c Author: Dmitry Torokhov <dtor@chromium.org> Date: Thu Oct 19 19:56:47 2017 Revert "CHROMIUM: HID: usbhid: get/put around clearing needs_remote_wakeup" This reverts commit d0b8047c47a35978f9181b8d22d6fc916817cb0b. Now that we have proper sequencing of power operations in hidraw, this change is no longer needed. BUG= chromium:764112 TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=431886 Change-Id: If2f54047fcd31d7e9c6594cb65cf11a3af4b52d9 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/721808 Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit b93bd996d15c7403a4c896d57b3013bd05e0cc09) Reviewed-on: https://chromium-review.googlesource.com/723880 Reviewed-by: Benson Leung <bleung@chromium.org> [modify] https://crrev.com/296d003531f77b6d1c1bc2be5b560087be3dbc2c/drivers/hid/usbhid/hid-core.c
,
Oct 19 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bleung@google.com
, Sep 11 2017