Hello,

About this issue... what kind of review would be required? Also, what specifically about the strings is not appropriate?

By the way, I did build chrome_app with mac_views_browser, and the first thing I noticed is that "Restore tabs" showed up as a bubble window, rather than a ribbon, so I'm not sure if that is the intended behaviour. 

one of the dialog modes refers to autoupdate, and tries to spawn setup.exe. Its unlikely that will work as expected on Mac. It might be fine, just needs review.

Bubbles are fine. Mac lags behind converting infobar UI into bubbles, which was the intention for a lot of these.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1cad53e2dc5a39c54789f9f6d93344c9c3e3aa1

commit f1cad53e2dc5a39c54789f9f6d93344c9c3e3aa1
Author: Elly Fong-Jones <ellyjones@google.com>
Date: Tue Mar 20 17:34:30 2018

polychrome: fix OutdatedUpgradeBubbleTest suite

These tests:
a) Require a Views browser window, since OutdatedUpgradeBubble can't show in
   a Cocoa window;
b) Don't work on Mac anyway, since OutdatedUpgradeBubble is ifdef'd out there

This change marks them as Views-only for polychrome and disables them on Mac
with a comment pointing at the bug to implement OutdatedUpgradeBubble there.

Bug: 817408,764111
Change-Id: Iac4ebf0d36c0749a64b0c197ed27ba168643e94d
Reviewed-on: https://chromium-review.googlesource.com/970745
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544424}
[modify] https://crrev.com/f1cad53e2dc5a39c54789f9f6d93344c9c3e3aa1/chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc

MacViews triage: support for this dialog will probably have to wait until after M-69. Marking this as M-X.

We're not targeting this for M69 as it's marked M-X

**Mass UI Triage**

@tapted : Could you please help in verifying the issue ?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e

commit 632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Jan 17 05:11:56 2019

Re-enable disabled tests in chrome/browser/ui/views/toolbar/.

Bug: 163931,  401304 , 617056, 764111,  788112 , 823543, 824418
Change-Id: I6c1a8be7f5d30e0082b69af12aceb35851ce2f51
Reviewed-on: https://chromium-review.googlesource.com/c/1351805
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623589}
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.cc
[modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.h

I enabled the dialog for Mac in r623589.  I meant to get a Mac person to review and then didn't.  Oops :(

Elly, can you take a glance at the Mac dialog (or find someone who can) so we can ensure this was OK?  If it's not OK, I can either help fix or re-disable.

If it is OK, we can mark this Fixed.