Network settings: adjust wording and iconography for Mobile data and Wi-Fi |
||||||||||||||
Issue descriptionUX has provided us with new mocks for the settings page. Now, when no mobile network is connected, the text "Not connected" is displayed instead of "No network". Question: Should this change also occur for Wi-Fi networks? I see no reason why they should be different.
,
Sep 15 2017
Thanks! I want to confirm that my understanding is correct. Is this what you are thinking? For both Wi-Fi and Mobile data networks: (1) If connected, display: the connected network's name (2) If not connected, but there are available networks to join, display: "Not connected" (3) If not connected, and there are no networks to join, display: "No network"
,
Sep 15 2017
If not connected, but there are "available networks to join" and "no networks to join" display: "No network".
,
Sep 15 2017
Can you clarify? Are you saying that we should display "No network" if there are networks available and also display "No network" if there are no networks available?
,
Sep 15 2017
We agree with what you proposed. For both Wi-Fi and Mobile data networks: (1) If connected, display: the connected network's name (2) If not connected, but there are available networks to join, display: "Not connected" (3) If not connected, and there are no networks to join, display: "No network"
,
Sep 28 2017
,
Oct 3 2017
,
Oct 3 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a commit 7eabc099a4dcbf647d1bffcf009df0fff6b5b33a Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Oct 04 02:21:01 2017 [CrOS Tether] Update strings shown in the settings network summary. For both Wi-Fi and Mobile data networks: (1) If connected, display: the connected network's name (2) If not connected, but there are available networks to join, display: "Not connected" (3) If not connected, and there are no networks to join, display: "No network" This CL also adds the "cellular off" icon, which is displayed in these cases. Bug: 764110 , 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If502538dd1e52e93ebead098d97cd3bc5080c871 Reviewed-on: https://chromium-review.googlesource.com/699634 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#506279} [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/resources/chromeos/network_ui/network_ui.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/resources/settings/internet_page/network_summary_item.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/chrome/test/data/webui/settings/internet_page_tests.js [add] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/ui/webui/resources/cr_elements/chromeos/network/cellular_off.svg [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.html [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js [modify] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/ui/webui/resources/cr_elements_images.grdp
,
Oct 4 2017
,
Oct 16 2017
1. When it's "no network", please use the light grey no signal icon for both. (see the screenshot) 2. For "not connected", use the icon with "x" for both. 3. For "off", use the icon with slash for both. You can find the "not connected" wi-fi icon (not-connected-wifi) here: https://drive.google.com/open?id=0B_2Uyb2Rhx2OVmJRY2tnbDYyT28
,
Oct 16 2017
,
Oct 16 2017
Thanks, Elizabeth. A few follow-up questions - should these design decisions affect the subpages/detail pages as well? (1) A subpage is the page that is shown when you click the small arrow on the network summary; the subpage shows a list of networks of the given type that the user can connect to. (2) A detail page is the page that is shown when you click the small arrow next to a network on the subpage; the detail page shows a single network's properties.
,
Oct 16 2017
The changes shouldn't affect the subpages and detail pages.
,
Oct 20 2017
,
Oct 27 2017
Any updates?
,
Nov 7 2017
Hi gkihumba@. Sorry about that - I was OOO for the past 10 days. I will be working on this bug and plan to have a fix ready in the next couple days. Thanks for understanding!
,
Nov 10 2017
Fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/762598 Also renaming this bug since it has become more than just wording.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dd661fa07ba6c406d331aa051744803c678bb58 commit 0dd661fa07ba6c406d331aa051744803c678bb58 Author: Kyle Horimoto <khorimoto@google.com> Date: Fri Nov 10 03:50:53 2017 [CrOS Tether] Update network iconography in settings page. This CL changes icons such that: (1) If no networks exist for the network type, a light-grey "0-bar" icon is displayed. (2) If at least one network exists for the network type but none of them are connected, a light-grey icon with an X is displayed. (3) If the network type is disabled, a darker strikethrough icon is displayed. (4) If a network is connecting, the icon is animated. (5) If a network is connected, an icon displaying the signal strength is displayed. Bug: 764110 , 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6 Reviewed-on: https://chromium-review.googlesource.com/762598 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515446} [modify] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/chrome/browser/resources/settings/internet_page/network_summary_item.html [add] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/ui/webui/resources/cr_elements/chromeos/network/cellular_0_with_x.svg [modify] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.html [modify] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.js [add] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/ui/webui/resources/cr_elements/chromeos/network/wifi_0_with_x.svg [modify] https://crrev.com/0dd661fa07ba6c406d331aa051744803c678bb58/ui/webui/resources/cr_elements_images.grdp
,
Nov 10 2017
,
Nov 11 2017
This bug requires manual review: There is .grd file changes and we are only 23 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 13 2017
,
Nov 13 2017
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c15ab38e61dd8a24f4cc685c71730293c748bbab commit c15ab38e61dd8a24f4cc685c71730293c748bbab Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Nov 13 21:46:01 2017 [CrOS Tether] Update network iconography in settings page. This CL changes icons such that: (1) If no networks exist for the network type, a light-grey "0-bar" icon is displayed. (2) If at least one network exists for the network type but none of them are connected, a light-grey icon with an X is displayed. (3) If the network type is disabled, a darker strikethrough icon is displayed. (4) If a network is connecting, the icon is animated. (5) If a network is connected, an icon displaying the signal strength is displayed. TBR=khorimoto@google.com (cherry picked from commit 0dd661fa07ba6c406d331aa051744803c678bb58) Bug: 764110 , 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6 Reviewed-on: https://chromium-review.googlesource.com/762598 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515446} Reviewed-on: https://chromium-review.googlesource.com/767351 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#470} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/chrome/browser/resources/settings/internet_page/network_summary_item.html [add] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/ui/webui/resources/cr_elements/chromeos/network/cellular_0_with_x.svg [modify] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.html [modify] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.js [add] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/ui/webui/resources/cr_elements/chromeos/network/wifi_0_with_x.svg [modify] https://crrev.com/c15ab38e61dd8a24f4cc685c71730293c748bbab/ui/webui/resources/cr_elements_images.grdp |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by elizabethchiu@chromium.org
, Sep 15 2017185 KB
185 KB View Download
188 KB
188 KB View Download