Adjust Mobile data quick settings rows |
||||||
Issue descriptionUX has provided us with new mocks which change the way that mobile data rows should appear in quick settings. Change 1: When a device is not connected, the mock shows a "Not connected" label, and the cellular signal strength icon is replaced by an icon with an X. I think we should rethink this issue a bit. When there are multiple devices in the list, signal strength is very valuable information when the user is deciding which device to connect because users probably would like to connect to the network with the best signal. I think removing this information is bad for users - perhaps we could think of another way to make it clear that the network is not connected. Additionally, when there are multiple devices in the list, I think that adding "Not connected" as part of each row will clutter the UI. Wi-Fi doesn't do this, so does it make sense to do this for Mobile networks? Change 2: Battery icon size has been reduced. Can you please provide clarification about what the correct icon size is?
,
Sep 15 2017
Signal Icon: Okay, I can do that! Can you please provide an asset for this? It should be in the form of an SVG which is the same size as the entire signal icon so that it can be superimposed on top of the signal icon. "Not connected" label: Are we no longer displaying that, then? Battery icon size: What is the intended size of the icon?
,
Sep 18 2017
#3 'Not connected' label - Yes, let's not show the label. Elizabeth with provide the asset for the not connected icon and battery.
,
Sep 23 2017
Here are the updated "not connected" + battery icons and the spec: https://drive.google.com/open?id=0B_2Uyb2Rhx2OSGhSVnRUSzQzU0E https://drive.google.com/open?id=0B_2Uyb2Rhx2OVmJRY2tnbDYyT28 Please let me know if there's any icons missing.
,
Sep 23 2017
,
Sep 28 2017
,
Sep 28 2017
Hey Elizabeth - we still need an asset for the ✖ symbol. It looks like you included an asset which is the cellular bars as well as the ✖ in one image. However, we already have cellular icons in Chrome, so what we really need is an SVG which is the same size as the entire signal icon so that it can be superimposed on top of it. Thanks!
,
Sep 29 2017
Hi Elizabeth - the dimensions are incorrect. It should be 16x16 for the 1x image and 32x32 for the 2x image.
,
Sep 29 2017
Oops - my earlier comment was incorrect. We need 24x24 for 1x and 48x48 for 2x.
,
Sep 30 2017
,
Sep 30 2017
Just updated the files. You can find them in the assets folder. https://drive.google.com/open?id=0B_2Uyb2Rhx2OVmJRY2tnbDYyT28
,
Oct 3 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb commit f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Oct 04 01:56:10 2017 [CrOS Tether] Display an X next to the cellular icon when disconnected. This CL updates the mobile data section of network settings so that when a mobile network is not connected, an X is displayed as part of the icon to indicate clearly to users that the network is not connected. Without this icon, some users were confused and thought that they were connected to a mobile network when they actually were not. Bug: 764107 , 672263 Change-Id: If1e10e838bffd5ab37cd9909fd02f448fefa3956 Reviewed-on: https://chromium-review.googlesource.com/693420 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506272} [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/resources/vector_icons/network_mobile_not_connected_x.1x.icon [add] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/resources/vector_icons/network_mobile_not_connected_x.icon [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/system/network/network_list.cc [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/system/tray/hover_highlight_view.h [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/system/tray/tray_constants.cc [modify] https://crrev.com/f566a4c3f0c84092f760fca4b9bc492b1fe3c5bb/ash/system/tray/tray_constants.h
,
Oct 4 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xiy...@chromium.org
, Sep 15 2017