Page Lifecycle: Instrument unload / beforeunload |
||
Issue descriptionInstrument unload / beforeunload / pagehide to figure out restrictions & feasibility of waitUntil support etc for Lifecycle - duration of handler: total wall time; also actual CPU time - which user exit scenario (nav vs close tab) -- blink does not have this signal, could plumb from browser? - usage / usecounter for sync / async XHR within unload - how often does unload NOT complete eg. we kill the tab on timeout etc
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a6413259946be7739be0104104335da100f8bf6 commit 2a6413259946be7739be0104104335da100f8bf6 Author: Shubhie Panicker <panicker@chromium.org> Date: Fri Sep 15 23:01:14 2017 Add UMA for duration for unload events: beforeunload, unload, pagehide, visibilitychange Bug: 764104 Change-Id: Iee096039e1f457d2794f6b527cce84f3caaa55ab Reviewed-on: https://chromium-review.googlesource.com/661860 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502422} [modify] https://crrev.com/2a6413259946be7739be0104104335da100f8bf6/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/2a6413259946be7739be0104104335da100f8bf6/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp [modify] https://crrev.com/2a6413259946be7739be0104104335da100f8bf6/third_party/WebKit/Source/core/loader/DocumentLoadTiming.h
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59b6eb640b81c27203cafa4aabe272596d8a14e9 commit 59b6eb640b81c27203cafa4aabe272596d8a14e9 Author: Shubhie Panicker <panicker@chromium.org> Date: Mon Oct 02 22:50:12 2017 Add usecounter for counting occurences of XHR within page dismissal (unload path) and histogram to see the distribution across callbacks (unload, pagehide etc) Bug: 764104 Change-Id: Ic7ea74c5b79e35cee3935e3697f539ea668980d0 Reviewed-on: https://chromium-review.googlesource.com/668140 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505828} [modify] https://crrev.com/59b6eb640b81c27203cafa4aabe272596d8a14e9/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/59b6eb640b81c27203cafa4aabe272596d8a14e9/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/59b6eb640b81c27203cafa4aabe272596d8a14e9/tools/metrics/histograms/enums.xml
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8 commit 9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8 Author: Shubhie Panicker <panicker@chromium.org> Date: Tue Oct 24 02:50:12 2017 Add updates to histograms.xml for xhr during unload. Previously UMAs were added for xhr during unload, but missed updating histograms.xml. UMA records occurence of async and sync XHR durng unload pagedismissal states. Related: CL/668140 Bug: 764104 Change-Id: I56563fccad5a4845223eb02df46723cc8eaeb9d3 Reviewed-on: https://chromium-review.googlesource.com/731185 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#511019} [modify] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/tools/metrics/histograms/histograms.xml
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/811d24443444c0b997813d365ab8aa663ee2cea0 commit 811d24443444c0b997813d365ab8aa663ee2cea0 Author: Shubhie Panicker <panicker@chromium.org> Date: Wed Oct 25 05:59:20 2017 Add updates to histograms.xml for unload instrumentation. Previously UMAs were added for unload instrumentation, but missed updating histograms.xml in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/661860 UMAs cover duration for unload events: beforeunload, unload, pagehide, visibilitychange and result of beforeunload (whether to show dialog). Bug: 764104 Change-Id: I1b0efeeaa27d8270fae305ebe0446135154c8481 Reviewed-on: https://chromium-review.googlesource.com/729249 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#511390} [modify] https://crrev.com/811d24443444c0b997813d365ab8aa663ee2cea0/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/811d24443444c0b997813d365ab8aa663ee2cea0/tools/metrics/histograms/enums.xml [modify] https://crrev.com/811d24443444c0b997813d365ab8aa663ee2cea0/tools/metrics/histograms/histograms.xml
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ea958f5a2fda9758d8ed517b48f5a87f77dc633 commit 1ea958f5a2fda9758d8ed517b48f5a87f77dc633 Author: Shubhie Panicker <panicker@chromium.org> Date: Fri Nov 10 08:14:25 2017 Add usecounter for pagehide, pageshow Bug: 764104 Change-Id: I45cd6ae2d0d4911e0f156e53333080c7e2bf53ba Reviewed-on: https://chromium-review.googlesource.com/762118 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#515504} [modify] https://crrev.com/1ea958f5a2fda9758d8ed517b48f5a87f77dc633/third_party/WebKit/Source/core/dom/events/EventTarget.cpp [modify] https://crrev.com/1ea958f5a2fda9758d8ed517b48f5a87f77dc633/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/1ea958f5a2fda9758d8ed517b48f5a87f77dc633/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/1ea958f5a2fda9758d8ed517b48f5a87f77dc633/tools/metrics/histograms/enums.xml
,
Sep 12
|
||
►
Sign in to add a comment |
||
Comment 1 by panicker@chromium.org
, Sep 15 2017