[Sync] UserEvents DCHECK |
|||
Issue descriptionCreated a local html file that redirected to itself during onload via window.location.replace. [134012:134012:0911/155302.594341:FATAL:processor_entity_tracker.cc(220)] Check failed: data.response_version > metadata_.server_version() (1 vs. 1) #0 0x7fd042fc9eed base::debug::StackTrace::StackTrace() #1 0x7fd042fc82bc base::debug::StackTrace::StackTrace() #2 0x7fd04305910a logging::LogMessage::~LogMessage() #3 0x558ea1165b21 syncer::ProcessorEntityTracker::ReceiveCommitResponse() #4 0x558ea101f842 syncer::SharedModelTypeProcessor::OnCommitCompleted() #5 0x558e9ee0cbdf _ZN4base8internal13FunctorTraitsIMN10extensions11ImageLoaderEFvRKNS_17RepeatingCallbackIFvN3gfx11ImageFamilyEEEERKNSt3__16vectorINS3_10LoadResultENSB_9allocatorISD_EEEEEvE6InvokeIRKNS_7WeakPtrIS3_EEJSA_SI_EEEvSK_OT_DpOT0_ #6 0x558ea1155685 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS4_18CommitResponseDataENSA_9allocatorISC_EEEEERKNS_7WeakPtrIS5_EEJS9_SH_EEEvOT_OT0_DpOT1_ #7 0x558ea11555ed _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunImplIRKSI_RKNS9_5tupleIJSK_S6_SE_EEEJLm0ELm1ELm2EEEEvOT_OT0_NS9_16integer_sequenceImJXspT1_EEEE #8 0x558ea11554bc _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE3RunEPNS0_13BindStateBaseE #9 0x7fd042f751b1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7fd042fceb42 base::debug::TaskAnnotator::RunTask() #11 0x7fd04307da5f base::internal::IncomingTaskQueue::RunTask() #12 0x7fd043082dd4 base::MessageLoop::RunTask() #13 0x7fd043083057 base::MessageLoop::DeferOrRunPendingTask() #14 0x7fd043083d40 base::MessageLoop::DoWork() #15 0x7fd04308b4dc base::MessagePumpGlib::HandleDispatch() #16 0x7fd04308bc81 base::(anonymous namespace)::WorkSourceDispatch() #17 0x7fd02c5ece04 g_main_context_dispatch #18 0x7fd02c5ed048 <unknown> #19 0x7fd02c5ed0ec g_main_context_iteration #20 0x7fd04308b5df base::MessagePumpGlib::Run() #21 0x7fd043082594 base::MessageLoop::Run() #22 0x7fd04313960d base::RunLoop::Run() #23 0x558ea077511d ChromeBrowserMainParts::MainMessageLoopRun() #24 0x7fd03c6c75b6 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x7fd03c6cff9f content::BrowserMainRunnerImpl::Run() #26 0x7fd03c6bb2fb content::BrowserMain() #27 0x7fd03e3863f4 content::RunNamedProcessTypeMain() #28 0x7fd03e3890ce content::ContentMainRunnerImpl::Run() #29 0x7fd03e383bcd content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #30 0x7fd0438d38c5 service_manager::Main() #31 0x7fd03e38526f content::ContentMain() #32 0x558e9e8e618e ChromeMain #33 0x558e9e8e60a2 main #34 0x7fd029f7df45 __libc_start_main #35 0x558e9e8e5f84 <unknown> Received signal 6 #0 0x7fd042fc9eed base::debug::StackTrace::StackTrace() #1 0x7fd042fc82bc base::debug::StackTrace::StackTrace() #2 0x7fd042fc98a5 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fd043631330 <unknown> #4 0x7fd029f92c37 gsignal #5 0x7fd029f96028 abort #6 0x7fd042fc5286 base::debug::(anonymous namespace)::DebugBreak() #7 0x7fd042fc5268 base::debug::BreakDebugger() #8 0x7fd043059dc6 logging::LogMessage::~LogMessage() #9 0x558ea1165b21 syncer::ProcessorEntityTracker::ReceiveCommitResponse() #10 0x558ea101f842 syncer::SharedModelTypeProcessor::OnCommitCompleted() #11 0x558e9ee0cbdf _ZN4base8internal13FunctorTraitsIMN10extensions11ImageLoaderEFvRKNS_17RepeatingCallbackIFvN3gfx11ImageFamilyEEEERKNSt3__16vectorINS3_10LoadResultENSB_9allocatorISD_EEEEEvE6InvokeIRKNS_7WeakPtrIS3_EEJSA_SI_EEEvSK_OT_DpOT0_ #12 0x558ea1155685 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS4_18CommitResponseDataENSA_9allocatorISC_EEEEERKNS_7WeakPtrIS5_EEJS9_SH_EEEvOT_OT0_DpOT1_ #13 0x558ea11555ed _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunImplIRKSI_RKNS9_5tupleIJSK_S6_SE_EEEJLm0ELm1ELm2EEEEvOT_OT0_NS9_16integer_sequenceImJXspT1_EEEE #14 0x558ea11554bc _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE3RunEPNS0_13BindStateBaseE #15 0x7fd042f751b1 _ZNO4base12OnceCallbackIFvvEE3RunEv #16 0x7fd042fceb42 base::debug::TaskAnnotator::RunTask() #17 0x7fd04307da5f base::internal::IncomingTaskQueue::RunTask() #18 0x7fd043082dd4 base::MessageLoop::RunTask() #19 0x7fd043083057 base::MessageLoop::DeferOrRunPendingTask() #20 0x7fd043083d40 base::MessageLoop::DoWork() #21 0x7fd04308b4dc base::MessagePumpGlib::HandleDispatch() #22 0x7fd04308bc81 base::(anonymous namespace)::WorkSourceDispatch() #23 0x7fd02c5ece04 g_main_context_dispatch #24 0x7fd02c5ed048 <unknown> #25 0x7fd02c5ed0ec g_main_context_iteration #26 0x7fd04308b5df base::MessagePumpGlib::Run() #27 0x7fd043082594 base::MessageLoop::Run() #28 0x7fd04313960d base::RunLoop::Run() #29 0x558ea077511d ChromeBrowserMainParts::MainMessageLoopRun() #30 0x7fd03c6c75b6 content::BrowserMainLoop::RunMainMessageLoopParts() #31 0x7fd03c6cff9f content::BrowserMainRunnerImpl::Run() #32 0x7fd03c6bb2fb content::BrowserMain() #33 0x7fd03e3863f4 content::RunNamedProcessTypeMain() #34 0x7fd03e3890ce content::ContentMainRunnerImpl::Run() #35 0x7fd03e383bcd content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #36 0x7fd0438d38c5 service_manager::Main() #37 0x7fd03e38526f content::ContentMain() #38 0x558e9e8e618e ChromeMain #39 0x558e9e8e60a2 main #40 0x7fd029f7df45 __libc_start_main #41 0x558e9e8e5f84 <unknown> r8: 00007fff033f7108 r9: fffffffffffffec8 r10: 0000000000000008 r11: 0000000000000202 r12: 000030b0fc21d7a0 r13: 0000000000000000 r14: 00007fd04308bc60 r15: 000030b0fc063480 di: 0000000000020b7c si: 0000000000020b7c bp: 00007fff033f7610 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: 00007fd029f92c37 sp: 00007fff033f74d8 ip: 00007fd029f92c37 efl: 0000000000000202 cgf: dead000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated.
,
Sep 11 2017
{
"CLIENT_TAG_HASH": "",
"CREATION_TIME": "Wednesday, December 31, 1969 at 4:00:00 PM",
"ID": "",
"MODIFICATION_TIME": "Wednesday, December 31, 1969 at 4:00:00 PM",
"NON_UNIQUE_NAME": "13149643956882650",
"PARENT_ID": "",
"UNIQUE_POSITION": "INVALID[]",
"metadata": {
"acked_sequence_number": "79",
"base_specifics_hash": "8qJawffAIqHiU77oQnGjQykveWg=",
"client_tag_hash": "/QKfwPiv2R/NmFDNCRtrMZUASyw=",
"creation_time": "1505170356882",
"is_deleted": false,
"modification_time": "1505170382427",
"sequence_number": "136",
"server_id": "_",
"server_version": "1",
"specifics_hash": "YPL6q4GsrwvhjzHUi3B/zWPIqK0="
},
"modelType": "User Events",
"user_event": {
"event_time_usec": "13149643956882650",
"language_detection_event": {
"detected_languages": [
{
"is_reliable": false,
"language_code": "und"
}
]
},
"navigation_id": "13149643982422333",
"session_id": "-2034019637196586948"
}
}
,
Sep 11 2017
I think the file:/// page was actually a red herring, since we don't create translate events for those. I think this crash actually happened from data I had created a minutes prior by opening lots of tabs and browsing to maps.google.com, which has on page redirects as well. The problem is that, when the GlobalIdMapper logic kicks in when a page is refreshed, we will recommit that user event. The problem though, I think, is that the version always comes back as 1. We assume that the server version > the local version. The local version is typically a nice -1, unless we've committed it and the record was dirty when the commit comes back. Most types I think have the version set to the current timestamp, but the server doesn't seem to be doing anything here. And how could it! We don't actually send the version to the server. They must use the default of 0, since it isn't set, and then add 1 to that, and return.
,
Sep 12 2017
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bcdb9e719c60eae28a40d4a826a5d49a22916d3 commit 6bcdb9e719c60eae28a40d4a826a5d49a22916d3 Author: Sky Malice <skym@chromium.org> Date: Thu Sep 21 22:13:10 2017 [Sync] Don't DCHECK on version for commit only types. To save bandwidth for commit only types we strip off various peices of metadata on commits. This includes versions. The previous contract was that version should always increase by at least 1, which the server respects as best it can, but to mechanisms that are tracking the version before it is stripped, things seem weird. The solution taken here was to remove the checking logic when we know the verison is going to be meaningless. Bug: 764103 Change-Id: Ia41a42ce0c17985a3dedad43e059e51313a1f316 Reviewed-on: https://chromium-review.googlesource.com/677624 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#503580} [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/engine_impl/model_type_worker.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/engine_impl/model_type_worker.h [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/model_impl/processor_entity_tracker.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/model_impl/processor_entity_tracker.h [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/model_impl/processor_entity_tracker_unittest.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/model_impl/shared_model_type_processor.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/model_impl/shared_model_type_processor_unittest.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/test/engine/mock_model_type_worker.cc [modify] https://crrev.com/6bcdb9e719c60eae28a40d4a826a5d49a22916d3/components/sync/test/engine/mock_model_type_worker.h
,
Sep 21 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by s...@chromium.org
, Sep 11 20178.3 KB
8.3 KB Download