zlib: Reorganize folder structure |
|||||
Issue descriptionCurrently the zlib used by Chromium has Intel specific optimizations applied on the top level folder. This is undesirable as it violates the design used in zlib upstream where platform specific optimizations are hosted in a 'contrib' folder. One of the active zlib forks (zlib-ng) follows a similar idea, but organizing CPU architecture specific code accordingly (i.e.: https://github.com/Dead2/zlib-ng/tree/develop/arch). We introduced the 'contrib' folder structure in the first ARM specific optimization (https://chromium-review.googlesource.com/c/chromium/src/+/627098). With the objective of trying to upstream this patches and making Chromium's zlib fork more manageable, the idea is to move the Intel specific code to a new folder tentatively called 'contrib/x86'. Advantages: a) That will allow the removal of the '.patch' files in the top directory b) Chromium's zlib will become more similar with upstream (both canonical zlib and zlib-ng) c) This will allow better odds of upstreaming this optimizations Optimizations that are not architecture specific can be hosted in a neutral folder (e.g. contrib/chromium-portable).
,
Sep 11 2017
,
Sep 11 2017
,
Sep 11 2017
Another side effect of this re-organization is to allow easier and faster updates with new releases of zlib, thus decreasing the window where Chromium (and its dependencies) will ship with an outdated zlib.
,
Sep 11 2017
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4fd3cb6f5a3998fef542abb432dc39352708a3c commit e4fd3cb6f5a3998fef542abb432dc39352708a3c Author: Adenilson Cavalcanti <adenilson.cavalcanti@arm.com> Date: Thu Sep 21 18:59:56 2017 Moving zlib patches to a new folder The idea is to help avoid constant merge conflicts in new patches on top of Chromium's zlib. Plus adding instructions on how to generate a patch file. Bug: 764094 Change-Id: I90260c7b6514171c4cc927a0299acf82b4ca6c2b Reviewed-on: https://chromium-review.googlesource.com/677495 Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#503523} [modify] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/README.chromium [rename] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/patches/0000-build.patch [rename] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/patches/0001-simd.patch [rename] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/patches/0002-uninitializedcheck.patch [rename] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/patches/0003-use-defines-for-inffast.patch [add] https://crrev.com/e4fd3cb6f5a3998fef542abb432dc39352708a3c/third_party/zlib/patches/README
,
Aug 13
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cavalcantii@chromium.org
, Sep 11 2017