New issue
Advanced search Search tips

Issue 764072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

"not used" warning when building crcmod on amd64-generic-tot-asan-informational

Project Member Reported by osh...@chromium.org, Sep 11 2017

Issue description


https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-asan-informational/builds/14328


Looks like this is a side effect of Don's fix.
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/658041

Don, is it possible to remove -Wunused-but-set-variable for this target somehow?

log:
11:05:49: WARNING: FORCING LOCAL INSTALL OF CRCMOD.
11:05:49: INFO: RunCommand: sudo -- pip install --ignore-installed crcmod
11:05:49: NOTICE: ts_mon was set up.
11:05:49: INFO: Attempting refresh to obtain initial access_token
11:05:49: INFO: Refreshing access_token
Downloading/unpacking crcmod
  Running setup.py (path:/tmp/pip_build_root/crcmod/setup.py) egg_info for package crcmod
    
Installing collected packages: crcmod
  Running setup.py install for crcmod
    building 'crcmod._crcfunext' extension
    x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.7 -c python2/src/_crcfunext.c -o build/temp.linux-x86_64-2.7/python2/src/_crcfunext.o
    python2/src/_crcfunext.c: In function ‘init_crcfunext’:
    python2/src/_crcfunext.c:492:13: warning: variable ‘m’ set but not used [-Wunused-but-set-variable]
       PyObject *m;
                 ^
    x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/python2/src/_crcfunext.o -o build/lib.linux-x86_64-2.7/crcmod/_crcfunext.so
    
Successfully installed crcmod
Cleaning up...
 
No, but that install is a huge temporary hack that should go away after we understand why it's needed.
See this for the reasoning.

 https://crbug.com/763438 
Status: WontFix (was: Assigned)

Comment 4 by osh...@chromium.org, Sep 12 2017

Blockedon: 763438
Cc: dgarr...@chromium.org
Owner: ----
Status: Available (was: WontFix)
Let's keep this open so that gardener can track this issue.
We'll close when 763438 is fixed.
The entirety of this issue is that a warning message was generated. It caused no errors.

It's not why the listed builder is failing.

https://luci-logdog.appspot.com/v/?s=chromiumos%2Fbb%2Fchromiumos%2Fx86-generic-incremental%2F36340%2F%2B%2Frecipes%2Fsteps%2FBuildPackages%2F0%2Fstdout

This is why amd64-generic-tot-asan-informational is failing:

10:04:53: ERROR: Cannot find prebuilts for chromeos-base/chromeos-chrome on x86-generic

It currently (correctly or not) requires a binary prebuilt for Chrome, but there isn't one available.

I don't THINK we've ever generated that prebuilt, so it's probably incorrect for the builder to require it.

Comment 6 by osh...@chromium.org, Sep 12 2017

So do we/you know why the build step is marked as read?

I just learned that x86-generic is obsolete, so that failure is most likely expected. Let me keep this open to pass this info to next gardener.

Comment 7 by osh...@chromium.org, Sep 12 2017

Actually, the failure in #1 is on amd64 (which is valid) and it's asan error, so it's different issue.
Blockedon: -763438
Scroll down the details pages, and you'll see other stages marked as red.

The current build UI doesn't show this (a new one currently in development does), but many of the stages are nested. If an inner stage fails, the outer stage that contains it will also turn red. The cbuildbot stage contains most other stages.

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f25bc86969dbbc8b9502187d5d03e10e724af328

commit f25bc86969dbbc8b9502187d5d03e10e724af328
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 12 19:54:48 2017

cbuildbot_launch: Hide pip install output.

The output of the pip install command contains a warning that has
confused multiple people, so hiding that output. Also add bug number
to log message.

BUG= chromium:764072 
TEST=cbuildbot_launch_unittest

Change-Id: I3ac521d38ce4534605f51428b97055f8e3a25c54
Reviewed-on: https://chromium-review.googlesource.com/663759
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>

[modify] https://crrev.com/f25bc86969dbbc8b9502187d5d03e10e724af328/scripts/cbuildbot_launch.py

Status: Fixed (was: Available)

Sign in to add a comment