New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764063 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 774223



Sign in to add a comment

Eve dims screen while handwriting

Project Member Reported by tbuck...@chromium.org, Sep 11 2017

Issue description

When I put Eve into tablet mode and take notes (eg. with Squid), my hand will occasionally cover the camera/light sensor. Currently this causes the screen to dim, which can be surprising / distracting while taking notes. We should avoid dimming the screen while taking notes.
 

Comment 1 by snanda@chromium.org, Sep 11 2017

Cc: puthik@chromium.org tbroch@chromium.org snanda@chromium.org
Owner: derat@chromium.org
Tom, could you please file a feedback report and ping us the feedback ID? We'll likely want to take a look at powerd logs.

Do you have a sense of how long your hand is covering ALS when this happens?

Comment 2 by derat@chromium.org, Sep 11 2017

Cc: derat@chromium.org
Owner: puthik@chromium.org
Over to Opal since he's been working on eve ALS levels. I'm not supportive of plumbing the fact that the user is taking a note into powerd, though.
Couldn't we just filter the ALS more aggressively? We already filter it after all... It's not like your hand will hang in front of it forever, you are going to eventually get tired :)

Comment 4 by puthik@chromium.org, Sep 12 2017

Currently we read ALS every second.[1] And we change brightness if it is at next step 2 times [2]

[1] http://cs/chromeos_public/src/platform2/power_manager/powerd/system/ambient_light_sensor.cc?l=35
[2] http://cs/chromeos_public/src/platform2/power_manager/powerd/policy/ambient_light_handler.cc?l=22

I think 2 seconds is a bit to low. I propose that we should change it to 10 seconds.

Comment 5 by puthik@chromium.org, Sep 12 2017

Cc: yungleem@chromium.org
Also +Yung

Comment 6 by derat@chromium.org, Sep 12 2017

So we'd always wait ten seconds before responding to brightness changes, regardless of how large they are? That seems like it could be problematic.

Comment 7 by puthik@chromium.org, Sep 12 2017

For me, I think that the 10 seconds lag between ambient and panel brightness change is acceptable.

Comment 8 by puthik@chromium.org, Feb 22 2018

I saw 1 user feedback handwriting make screen brightness adjust in past 90 days.
https://listnr.corp.google.com/report/85044744599

I think this is probably rare enough to be wontfix since we don't have good solution for this.

Comment 9 by puthik@chromium.org, Feb 22 2018

Status: WontFix (was: Assigned)
Labels: Hotlist-Bradbury
Status: Assigned (was: WontFix)
I wouldn't use feedback reports as the signal that this is rare. I think it makes the stylus writing experience clearly worse, but still possible. Just watching other people use stylus, many of them are initially puzzled at why their device is suddenly so dim while taking notes.

Could we be more gradual, or look at when/where the stylus was last used before dimming? If it's nearby the camera, that's a sign that the user's hand is likely covering the sensor rather than the room suddenly getting darker.

Comment 11 by derat@chromium.org, Feb 22 2018

Labels: -Restrict-View-Google
powerd (the thing that adjusts the backlight brightness) unfortunately doesn't know anything about stylus events (which are processed by Chrome).

I'd be okay with changes that added a D-Bus method to powerd that Chrome could call to say "stop doing ALS-triggered adjustments" and "start doing them again".

Comment 12 by derat@chromium.org, Feb 22 2018

Components: -OS>Kernel>Display OS>Kernel>Power
perhaps disable auto-brightness control when stylus is in use?  I think we can certainly do better.  Also should we also look at touchscreen events as well?  Probably similar issue as the stylus?
Cc: adlr@chromium.org
Components: Internals>Input>Touch>Screen
+1 for Dan's suggestion in #c11

+Adlr for his input as well.
+1 to #11.

@puthik will you take on adding that dbus method, and then we can call it from Chrome when the user is writing with stylus?

Comment 16 by puthik@google.com, Mar 20 2018

Dan owns powerd but if he didn't have time for that. I can take a look.

Comment 17 by derat@chromium.org, Mar 20 2018

Owner: tbuck...@chromium.org
I'll do the powerd side of this if you find an eng owner for the Chrome work, Tom.

Comment 18 by derat@chromium.org, Mar 20 2018

Blockedon: 774223
Please tie this in with the FR at issue 774223 for a setting to enable/disable automatic brightness adjustments. Then we can use the same mechanism to disable adjustments when the setting is disabled and when the user is using the stylus.
Thanks Dan, I'll look into these two issues together from the UI side.

Sign in to add a comment