Issue metadata
Sign in to add a comment
|
Shader compile error on Quirk |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3163.79 (Official Build) beta (64-bit) (cohort: Beta) OS: Win10 What steps will reproduce the problem? http://algassert.com/quirk#circuit=%7B%22cols%22%3A%5B%5B%22Z%5Et%22%5D%5D%7D What is the expected result? Like Firefox and Edge What happens instead? It gives compile error, it seems shader variables are not translated correctly by Angle like other browsers or something, also filed here https://github.com/Strilanc/Quirk/issues/378 Graphics Feature Status Canvas: Hardware accelerated CheckerImaging: Disabled Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Rasterization: Hardware accelerated Video Decode: Hardware accelerated Video Encode: Hardware accelerated WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_accelerated_vpx_decode disable_discard_framebuffer disable_framebuffer_cmaa disable_larger_than_screen_overlays exit_on_context_lost force_cube_complete msaa_is_slow scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap VPx decoding isn't supported well before Windows 10 creators update.: 616318, 667532 Applied Workarounds: disable_accelerated_vpx_decode Accelerated VPx decoding is hanging on some videos.: 654111 Applied Workarounds: disable_accelerated_vpx_decode Overlay sizes bigger than screen aren't accelerated on some Intel drivers: 720059 Applied Workarounds: disable_larger_than_screen_overlays Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Checker-imaging has been disabled via finch trial or the command line. Disabled Features: checker_imaging Version Information Data exported 9/12/2017, 12:23:12 AM Chrome version Chrome/61.0.3163.79 Operating system Windows NT 10.0.14393 Software rendering list version 13.10 Driver bug list version 10.28 ANGLE commit id 0d2ecb4ea992 2D graphics backend Skia/61 0eefc0552cfb5ac077560b7c2630c5bd475ea585- Command Line "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --enable-es3-apis --enable-webgl-draft-extensions --flag-switches-end Driver Information Initialization time 391 In-process GPU false Passthrough Command Decoder false Supports overlays false Sandboxed false GPU0 VENDOR = 0x8086, DEVICE= 0x0416 *ACTIVE* GPU1 VENDOR = 0x10de, DEVICE= 0x11fc Optimus false Optimus false AMD switchable false Desktop compositing Aero Glass Diagonal Monitor Size of \\.\DISPLAY1 15.5" Driver vendor Intel Corporation Driver version 20.19.15.4331 Driver date 11-18-2015 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 8 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (Intel(R) HD Graphics 4600 Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.0d2ecb4ea992) GL_EXTENSIONS GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Google Inc. (adapter LUID: 000000000000e2c7) Window system binding version 1.4 (ANGLE 2.1.0.0d2ecb4ea992) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only R_16 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 Software only BGRX_8888 Software only BGRA_8888 Software only RGBA_F16 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Diagnostics ... loading ... Log Messages [2376:11800:0910/134249.201:WARNING:angle_platform_impl.cc(41)] : rx::HLSLCompiler::compileToBinary(224): C:\fakepath(69,10-34): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them C:\fakepath(91,10-34): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them [2376:2432:0911/235534.666:WARNING:angle_platform_impl.cc(41)] : gl::Shader::resolveCompile(329): ERROR: 0:18: 'webgl_286cc28ba4512e72' : undeclared identifier ERROR: 0:18: 'assign' : l-value required (can't modify a const) ERROR: 0:19: 'webgl_d95d8e9804629e71' : undeclared identifier ERROR: 0:19: 'assign' : l-value required (can't modify a const) [2376:2432:0911/235534.666:ERROR:shader_manager.cc(116)] : Shader translator allowed/produced an invalid shader unless the driver is buggy: --Log from shader translator-- --original-shader-- precision highp float; precision highp int; uniform sampler2D _gen_ketgen_ket_tex; uniform vec2 _gen_ketgen_ket_size; vec2 read_ketgen_ket(float k) { vec2 uv = vec2(mod(k, _gen_ketgen_ket_size.x) + 0.5, floor(k / _gen_ketgen_ket_size.x) + 0.5) / _gen_ketgen_ket_size; return texture2D(_gen_ketgen_ket_tex, uv).xy; } float len_ketgen_ket() { return _gen_ketgen_ket_size.x * _gen_ketgen_ket_size.y; } uniform sampler2D _gen_ketgen_control_tex; uniform vec2 _gen_ketgen_control_size; float read_ketgen_control(float k) { vec2 uv = vec2(mod(k, _gen_ketgen_control_size.x) + 0.5, floor(k / _gen_ketgen_control_size.x) + 0.5) / _gen_ketgen_control_size; return float(texture2D(_gen_ketgen_control_tex, uv).x == 1.0); } float len_ketgen_control() { return _gen_ketgen_control_size.x * _gen_ketgen_control_size.y * 4.0; } vec2 outputFor(float k); uniform vec2 _gen_output_size; uniform float _gen_secret_half; float len_output() { return _gen_output_size.x * _gen_output_size.y; } void main() { vec2 xy = gl_FragCoord.xy - vec2(_gen_secret_half, _gen_secret_half); float k = xy.y * _gen_output_size.x + xy.x; vec2 v = outputFor(k); gl_FragColor = vec4(v.x, v.y, 0.0, 0.0); } uniform float _ketgen_step; float _ketgen_off; float full_out_id; vec2 cmul(vec2 c1, vec2 c2) { return mat2(c1.x, c1.y, -c1.y, c1.x) * c2; } vec2 inp(float k) { return read_ketgen_ket(_ketgen_off + _ketgen_step*k); } uniform vec2 a, b, c, d; vec2 _ketgen_output_for(float out_id, vec2 amp) { return cmul(inp(0.0), a+(c-a)*out_id) + cmul(inp(1.0), b+(d-b)*out_id); } vec2 outputFor(float k) { full_out_id = k; float relevant_out_id = mod(floor(full_out_id / _ketgen_step), 2.0); _ketgen_off = full_out_id - relevant_out_id*_ketgen_step; float c = read_ketgen_control(full_out_id); vec2 vc = read_ketgen_ket(full_out_id); vec2 vt = _ketgen_output_for(relevant_out_id, vc); return (1.0-c)*vc + c*vt; } --translated-shader-- --info-log-- ERROR: 0:18: 'webgl_286cc28ba4512e72' : undeclared identifier ERROR: 0:18: 'assign' : l-value required (can't modify a const) ERROR: 0:19: 'webgl_d95d8e9804629e71' : undeclared identifier ERROR: 0:19: 'assign' : l-value required (can't modify a const) (and lots more)
,
Sep 11 2017
,
Sep 11 2017
Olli's a good reference. Feel free to follow up with more suggestions Geoff.
,
Sep 11 2017
This looks like a regression, I can't reproduce it in Chrome M60 but can in Canary.
,
Sep 11 2017
bisect-builds gives a regression range of: https://chromium.googlesource.com/chromium/src/+log/4aba27cc3025b6a9e1f25d24d1f1950eed5c44aa..0fbaeef38e204c0a97c1792689a2d0fd4fb784ea which has an ANGLE regression range of: https://chromium.googlesource.com/angle/angle.git/+log/63d8c26..9216a6e Going to try to narrow it more
,
Sep 12 2017
This issue is related to global variable initialization. If a global variable is declared after main(), it's not visible where ANGLE tries to initialize it. Here's a simpler shader to reproduce the issue:
void main() {
gl_FragColor = vec4(0.0);
}
mediump float f;
It should be pretty simple to fix, I'll try to have a fix for ANGLE ready for review today. While the bug exists in the browser, apps can work around it by declaring their globals in the beginning of the shader.
,
Sep 12 2017
Thanks for investigating this. Are you sure about the solution as the 18th/19th line of the shader can be seen on https://github.com/Strilanc/Quirk/issues/378 doesn't seem to be is before main(), possibly there could be other issues also I guess worth to be fixed. Adding ReleaseBlock-Stable label as it is better to back port the fix to stable branches and upset other web communities, feel free to remove it if you don't agree on it. Thanks
,
Sep 12 2017
/and upset/to not upset/
,
Sep 12 2017
Here's a fix: https://chromium-review.googlesource.com/c/angle/angle/+/663158 The line numbers shown on the error message can be misleading, since they're from after the shader has already gone through one translation pass. Backporting the fix is unfortunately tricky, since the patch that caused the regression (ANGLE commit 83498433fc73cc016e0d81cd35c69088946713d5) fixed other bugs, and the new fix was only possible to implement correctly after a recent fairly large change to variable naming in ANGLE's GLSL output. Maybe a different fix could be done on top of an older version of ANGLE though, like reordering the global scope so that variable declarations always come before functions. Any input from other ANGLE developers on the backporting?
,
Sep 12 2017
Olli, when did the renaming land? We could potentially merge it out to 62, which is about seven weeks old at this point. We can't merge this to stable, they're very picky about what types of CL get merged out.
,
Sep 12 2017
The GLSL variable renaming patch landed August 31st. It also required a patch on Chromium side to fix tests that were written against the old behavior.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad commit a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad Author: Olli Etuaho <oetuaho@nvidia.com> Date: Tue Sep 12 15:52:29 2017 GLSL: Fix initializing globals declared after main() Initialize globals in a separate function instead of a block in the beginning of main(). This way it works also for globals declared after main(). BUG= chromium:764036 TEST=angle_end2end_tests Change-Id: I2fcbb97d046589301287757dc3dde5471172a3f6 Reviewed-on: https://chromium-review.googlesource.com/663158 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad/src/compiler/translator/Compiler.cpp [modify] https://crrev.com/a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad/src/tests/gl_tests/GLSLTest.cpp [modify] https://crrev.com/a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad/src/compiler/translator/DeferGlobalInitializers.cpp [modify] https://crrev.com/a16a84f38f803ffac2b5d6cf41e3bd4e3a5e21ad/src/compiler/translator/DeferGlobalInitializers.h
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0592154fdfaa910f6da59d414f2889cc8892148a commit 0592154fdfaa910f6da59d414f2889cc8892148a Author: Geoff Lang <geofflang@chromium.org> Date: Tue Sep 12 21:52:08 2017 Roll ANGLE 9d81537..9df395c https://chromium.googlesource.com/angle/angle.git/+log/9d81537..9df395c BUG= 762377 , chromium:764036 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ifb7bc5b6ea8c4a1495e17269e23ed74d3e36d705 Reviewed-on: https://chromium-review.googlesource.com/664078 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501413} [modify] https://crrev.com/0592154fdfaa910f6da59d414f2889cc8892148a/DEPS
,
Sep 13 2017
> While the bug exists in the browser, apps can work around it by declaring their globals in the beginning of the shader. > The line numbers shown on the error message can be misleading, since they're from after the shader has already gone through one translation pass. Thanks for the help :)
,
Sep 14 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/177569b1fe8b4d1c3aed6322a7e531513c2f9928 commit 177569b1fe8b4d1c3aed6322a7e531513c2f9928 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Thu Sep 14 12:45:21 2017 Roll skia/third_party/externals/angle2/ 06ef36b98..da8e257cb (38 commits) https://chromium.googlesource.com/angle/angle.git/+log/06ef36b98878..da8e257cba5a $ git log 06ef36b98..da8e257cb --date=short --no-merges --format='%ad %ae %s' 2017-09-12 mradev Number of views should match when Draw* is called 2017-09-13 geofflang Allow ReadPixels with GL_FLOAT type and EXT_color_buffer_half_float. 2017-09-12 geofflang Add GL_DEPTH_COMPONENT_24 as a depth format for surfaces. 2017-09-12 jmadill Remove Renderer11::markAllStateDirty. 2017-09-12 jmadill Lift AMD blit suppressions. 2017-09-12 jmadill Consolidate Index buffer application. 2017-09-12 jmadill D3D11: Consolidate Scissor state application. 2017-09-12 jmadill D3D11: Consolidate SRV and Sampler application. 2017-09-12 jmadill D3D11: Consolidate Viewport state application. 2017-09-12 jmadill D3D11: Consolidate Rasterizer State application. 2017-09-12 jmadill D3D11: Consolidate Blend State application. 2017-09-12 jmadill D3D11: Consolidate Depth Stencil State application. 2017-09-12 jmadill D3D11: Consolidate OMSetRenderTargets calls. 2017-09-12 jmadill Cleanup to Resource11's reset method. 2017-09-12 jmadill Context: Remove recompilation trigger impl method. 2017-09-12 jmadill Fix out-of-bounds reads in BlitFramebuffer. 2017-09-12 jmadill D3D11: Move TF state management to StateManager11. 2017-09-12 jmadill StateManager11: Add internal dirty bits for uniforms. 2017-09-12 jmadill D3D11: Consolidate constant buffer application. 2017-09-12 jmadill D3D11: Move Constant Buffer state to StateManager11. 2017-09-12 geofflang Include string.h for strncmp in ExtensionBehavior.cpp 2017-09-12 jmadill Cleanups to ResourceSerial. 2017-09-11 cwallez Allow compiling dEQP on Mac in Chromium checkout. 2017-09-11 jmadill Update Texture dirty bits documentation. 2017-09-12 mradev Fix viewport and scissor multiview updates in StatemanagerGL 2017-09-12 oetuaho GLSL: Fix initializing globals declared after main() 2017-01-09 yizhou.jiang ES31: Implement getMultisamplefv for D3D part. 2017-08-30 jie.a.chen ES31: Add glGetProgramInterfaceiv API 2017-07-14 oetuaho Refer to GLSL extensions through TExtension enum 2017-09-11 fjhenigman Add linux_angle_ozone_rel_ng to CQ. 2017-09-09 jmadill D3D: Refactor driver uniform application. 2017-09-09 jmadill ProgramD3D: Use more UniformTypeInfo. 2017-09-09 jmadill Fix EXTERNAL and 2D_ARRAY sampler type info. 2017-09-09 jmadill D3D: Only scan cached shader executable lists once. 2017-09-09 jmadill D3D11: Only update swizzles after a state change. 2017-09-09 jmadill D3D11: Implement dirty bits for texture updates. 2017-09-09 jmadill Move swizzling and program update to StateManager11. 2017-09-09 jmadill GL: Use dirty bits for texture and sampler bindings. Created with: roll-dep skia/third_party/externals/angle2 BUG= 764036 , 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=stephana@google.com Change-Id: Ic6e7cc57ddde2bfb397f5fa1b7db707f939817ad Reviewed-on: https://skia-review.googlesource.com/46440 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/177569b1fe8b4d1c3aed6322a7e531513c2f9928/DEPS
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49693a65662eb308ada90507d29b28acbb7045d9 commit 49693a65662eb308ada90507d29b28acbb7045d9 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Sep 14 16:48:20 2017 Roll src/third_party/skia/ 9b2f69b0a..d29f0e7cc (6 commits) https://skia.googlesource.com/skia.git/+log/9b2f69b0aacc..d29f0e7ccb84 $ git log 9b2f69b0a..d29f0e7cc --date=short --no-merges --format='%ad %ae %s' 2017-09-14 liyuqian Do not divide loops in PathBench 2017-09-14 caryclark name SkPixmap missing params 2017-09-13 benjaminwagner Remove redundant jobs. 2017-09-14 mtklein fix android roll 2017-09-14 robertphillips Finish restoring GrOpList DAG 2017-09-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 06ef36b98..da8e257cb (38 commits) Created with: roll-dep src/third_party/skia BUG= 764036 , 762377 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ida4bef07cae8177e3055466dd77b11853cfd97f6 Reviewed-on: https://chromium-review.googlesource.com/667119 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501967} [modify] https://crrev.com/49693a65662eb308ada90507d29b28acbb7045d9/DEPS
,
Sep 15 2017
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 15 2017
I hope it could be merged to 61 (or the culprit be reverted) but please consider it for 62 at least, even the fact I've prepared a hack for fixing the upstream.
,
Sep 15 2017
I don't know if this issue is serious enough to warrant a merge, since the merge would be pretty large. ebrahim@gnu.org, you said you have a workaround you can apply locally for the next couple months until 63 reaches stable? Marking as fixed since this is landed in Canary.
,
Sep 15 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 16 2017
> ebrahim@gnu.org, you said you have a workaround you can apply locally for the next couple months until 63 reaches stable? I meant the Quirk project, which has applied the workaround. > I don't know if this issue is serious enough to warrant a merge, since the merge would be pretty large. To be honest, I am also not that sure, we can see what feedbacks say.
,
Sep 18 2017
Can you please help quickly summarize what the issue is and it's potential broader impact?
,
Sep 18 2017
There hasn't been much feedback on the issue. I think given there's a pretty straight forward workaround, and the merge complexity is high, we should just wait for M63 to roll out.
,
Sep 20 2017
> Can you please help quickly summarize what the issue is and it's potential broader impact? It breaks some shaders on the web that are defining variable below main(), it is not expected to be that in use but interestingly it was breaking a site I was using which is now fixed. > There hasn't been much feedback on the issue. I think given there's a pretty straight forward workaround, and the merge complexity is high, we should just wait for M63 to roll out. No issue as I can't claim if it was that important without any telemetry and I provided a patch for the open-source project I was caring and it is merged, so. Also changing the milestone the fix decided to be landed if no back porting is in plan. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by zmo@chromium.org
, Sep 11 2017Labels: -Pri-3 OS-Windows Pri-2