New issue
Advanced search Search tips

Issue 764033 link

Starred by 2 users
Status: WontFix
Owner:
tommycli@chromium.org
Closed: Sep 2017
Cc:
jdonnelly@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Not seeing favicons with #omnibox-ui-show-suggestion-favicons

Project Member Reported by lgar...@chromium.org, Sep 11 2017 
Chrome 62.0.3202.9
macOS 10.12.6

What steps will reproduce the problem?
(1) Enable #omnibox-ui-show-suggestion-favicons
(2) Use the omnibox.

What is the expected result?
See some favicons, especially for bookmarks that show the favicon in the menu/bookmars bar.

What happens instead?
Just the page icon. :-(

I've attached a screenshot to show what omnibox flags I have enabbled.
Screen Shot 2017-09-11 at 12.51.48.png
301 KB View Download

Comment 1 by mpear...@chromium.org, Sep 11 2017

Cc: jdonnelly@chromium.org
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Assigning tentatively to tommycli@; jdonnelly to decide how much work should happen on this while he's out.

I'll note that sometimes Chrome doesn't have favicons for bookmarked pages.  For example, you can bookmark a page without ever visiting the URL.  In that case, Chrome will not have the favicon.  (But if other parts of Chrome UI are showing favicons for those URLs, that's obviously a bug...)

lgarron@,
Can you provide about:omnibox output that shows the URL being suggested for the input you want?  Please make sure it it's *identical* to the URL you see in the bookmarks bar with the favicon.

Comment 2 by lgar...@chromium.org, Sep 11 2017 

I don't see favicons for any omnibox dropdown suggestions at all.
Bookmarks show a star icon, everything else shows the default page icon.

I have https://hstspreload.org and https://webbluetoothcg.github.io/demos/playbulb-candle/ bookmarked, and have attached the chrome://omnibox for searches for both.
playb.html
27.6 KB View Download
hsts.html
61.9 KB View Download

Comment 3 by jdonnelly@chromium.org, Sep 13 2017

Status: WontFix (was: Assigned)
We enabled the flag on Mac in M62 but the Cocoa implementation didn't land until after the cut. If you want to try it out on Mac, you'll have to use 
Canary for now. Sorry for causing confusion.

Comment 4 by lgar...@chromium.org, Sep 15 2017 

Dev just updated to Chrome 63.0.3213.3 and I see the icons!
►

Sign in to add a comment