Add a Finch study to configure a set of 'expired' histograms. |
||||
Issue descriptionThis study should give a way to enable or disable recording of particular histograms regardless of their expiry dates. Its parameters should be used to filter expired histograms in the client code.
,
Oct 27 2017
,
May 3 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69 commit f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed May 23 19:50:47 2018 Always record for tests and whitelist expired histograms through field trial. Expired histogram logic is disabled by default and is enabled by field trial. The field trial will enable it for all the users. This is done so that unit tests don't use expired histogram logic otherwise unit tests can fail unexpectedly when histograms become expired. The same field trial also has "whitelist" param that will contain names of expired histograms that should be recorded. Bug: 764030 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I60bf53d0a4a4cf126873e150b2b3ee6645e7d173 Reviewed-on: https://chromium-review.googlesource.com/1064726 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#561216} [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/base/metrics/histogram_unittest.cc [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/base/metrics/statistics_recorder_unittest.cc [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/BUILD.gn [add] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/expired_histogram_util.cc [add] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/expired_histogram_util.h [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/expired_histograms_checker.cc [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/expired_histograms_checker.h [add] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/components/metrics/expired_histograms_checker_unittest.cc [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/ios/chrome/browser/ios_chrome_main_parts.mm [modify] https://crrev.com/f3ecb14502b14c35e4d43a4a0ee88f7d4f5fbe69/ios/chrome/browser/metrics/BUILD.gn
,
Jun 5 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Oct 27 2017Owner: ----
Status: Untriaged (was: Assigned)