Chrome Version: 63.0.3212.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Bring up the Bookmarks dialog What is the expected result? The dropdown title and textfield text position should match spec (see https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-05-dropdown-textfields.png ) What happens instead? The dropdown title and textfield text are too close to the left edge of their control. It looks like they need to move 3pt to the right. Probably occurs on Windows, etc., but it's not easy for me to check.
Assume cross-platform
I have this implemented locally and attached a screenshot of what it looks like in context.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dbdf7e7c253749bfff2f88aa53d793d9ac29679 commit 1dbdf7e7c253749bfff2f88aa53d793d9ac29679 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Sep 25 23:25:40 2017 Harmony - Change textfield insets and height to match the spec. This patch changes the horizontal textfield insets in Harmony to be 8pt, and changes the height to be 28pt by default. The height pre-Harmony is changed by 2pt because its preferred height was taking into account the border height as well, which is now fixed. Bug: 764019 Change-Id: Icce4cc6a0a0038ccb23077299475aca1415ff9b6 Reviewed-on: https://chromium-review.googlesource.com/676474 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#504209} [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/chrome/browser/ui/views/harmony/harmony_layout_provider.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/controls/focusable_border.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/controls/focusable_border.h [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/layout/layout_provider.cc [modify] https://crrev.com/1dbdf7e7c253749bfff2f88aa53d793d9ac29679/ui/views/layout/layout_provider.h
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-05-dropdown-textfields.png){kind=link}
Comment 1 by pkasting@chromium.org
, Sep 11 2017Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)