Issue metadata
Sign in to add a comment
|
IPCChannelProxyTest.GlobalAndMessageClassFilters and MessageClassFilters flaked on ipc_tests on Fuchsia |
||||||||||||||||||||||||
Issue descriptionIPCChannelProxyTest.GlobalAndMessageClassFilters timed out https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FFuchsia%2F9294%2F%2B%2Frecipes%2Fsteps%2Fipc_tests%2F0%2Fstdout
,
Feb 16 2018
Auto-assigning since I think this is the same root-cause as the other IPCChannelProxyTest failures; this may be a broken threading assumption (see https://bugs.chromium.org/p/chromium/issues/detail?id=754755#c2).
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6 commit 7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6 Author: Scott Graham <scottmg@chromium.org> Date: Fri Feb 16 22:07:12 2018 fuchsia: Disable a couple flaky tests Both from this run: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/16374 Bug: 764015 , 811881 Change-Id: If6954f1ded3ad61961dd60c994ef7d1d905351c9 Reviewed-on: https://chromium-review.googlesource.com/923431 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537426} [modify] https://crrev.com/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6/testing/buildbot/filters/fuchsia.base_unittests.filter [modify] https://crrev.com/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6/testing/buildbot/filters/fuchsia.ipc_tests.filter
,
Feb 21 2018
IPCChannelProxyTest.GlobalAndMessageClassFilters flaked again on Fuchsia/x64/Debug at https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia%20(dbg)/16501 with a timeout: [00456.578] 11943.11969> 3 thread(s) ... [00456.590] 11943.11969> <== Thread initial-thread[4568] ==> ... #01: pc 0x57fb66c1385b sp 0x7090b4c6e1a8 (<vDSO>,0x685b) #02: pc 0x57fb66c13579 sp 0x7090b4c6e1b0 (<vDSO>,0x6579) #03: pc 0x7e23f4a1b911 sp 0x7090b4c6e1d0 (libc.so,0x3c911) #04: pc 0x7e23f49ef348 sp 0x7090b4c6e210 (libc.so,0x10348) #05: base::ConditionVariable::Wait() at ??:? #06: base::WaitableEvent::TimedWaitUntil(base::TimeTicks const&) at ??:? #07: base::WaitableEvent::Wait() at ??:? #08: base::MessagePumpDefault::Run(base::MessagePump::Delegate*) at ??:? #09: base::MessageLoop::Run(bool) at ??:? #10: base::RunLoop::Run() at ??:? #11: (anonymous namespace)::IPCChannelProxyTest::SendQuitMessageAndWaitForIdle() at ??:? #12: (anonymous namespace)::IPCChannelProxyTest_GlobalAndMessageClassFilters_Test::TestBody() at ??:? #13: testing::Test* testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) at ??:? #14: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) at ??:? #15: testing::Test::Run() at ??:? #16: testing::TestInfo::Run() at ??:? #17: testing::TestCase::Run() at ??:? #18: testing::internal::UnitTestImpl::RunAllTests() at ??:? #19: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ??:? #20: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ??:? #21: testing::UnitTest::Run() at ??:? #22: RUN_ALL_TESTS() at ??:? #23: base::TestSuite::Run() at ??:? #24: int base::internal::FunctorTraits<int (base::TestSuite::*)(), void>::Invoke<base::TestSuite*>(int (base::TestSuite::*)(), base::TestSuite*&&) at ??:? #25: int base::internal::InvokeHelper<false, int>::MakeItSo<int (base::TestSuite::* const&)(), base::TestSuite*>(int (base::TestSuite::* const&)(), base::TestSuite*&&) at ??:? #26: int base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >, int ()>::RunImpl<int (base::TestSuite::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<base::TestSuite> > const&, 0ul>(int (base::TestSuite::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<base::TestSuite> > const&, std::__1::integer_sequence<unsigned long, 0ul>) at ??:? #27: base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >, int ()>::Run(base::internal::BindStateBase*) at ??:? #28: base::RepeatingCallback<void ()>::Run() const & at ??:? #29: base::(anonymous namespace)::LaunchUnitTestsInternal(base::RepeatingCallback<int ()> const&, unsigned long, int, bool, base::RepeatingCallback<void ()> const&) at ??:? #30: base::LaunchUnitTests(int, char**, base::RepeatingCallback<int ()> const&) at ??:? #31: main at ??:? #32: pc 0x7e23f49f250e sp 0x7090b4c6ffe0 (libc.so,0x1350e) #33: pc 0 sp 0x7090b4c70000 [00456.616] 11943.11969> <== Thread test_io_thread[5177] ==> ... #01: pc 0x57fb66c13889 sp 0x7acdb0707378 (<vDSO>,0x6889) #02: pc 0x57fb66c135b7 sp 0x7acdb0707380 (<vDSO>,0x65b7) #03: base::MessagePumpFuchsia::HandleEvents(unsigned long) at ??:? #04: base::MessagePumpFuchsia::Run(base::MessagePump::Delegate*) at ??:? #05: base::MessageLoop::Run(bool) at ??:? #06: base::RunLoop::Run() at ??:? #07: base::Thread::Run(base::RunLoop*) at ??:? #08: base::Thread::ThreadMain() at ??:? #09: base::(anonymous namespace)::ThreadFunc(void*) at ??:? #10: pc 0x7e23f49efc76 sp 0x7acdb0708fe0 (libc.so,0x10c76) #11: pc 0x7e23f4a65d19 sp 0x7acdb0708ff0 (libc.so,0x86d19) #12: pc 0 sp 0x7acdb0709000 [00456.629] 11943.11969> <== Thread ChannelProxyTestServerThread[10236] ==> ... #01: pc 0x57fb66c13889 sp 0x668d557d3378 (<vDSO>,0x6889) #02: pc 0x57fb66c135b7 sp 0x668d557d3380 (<vDSO>,0x65b7) #03: base::MessagePumpFuchsia::HandleEvents(unsigned long) at ??:? #04: base::MessagePumpFuchsia::Run(base::MessagePump::Delegate*) at ??:? #05: base::MessageLoop::Run(bool) at ??:? #06: base::RunLoop::Run() at ??:? #07: base::Thread::Run(base::RunLoop*) at ??:? #08: base::Thread::ThreadMain() at ??:? #09: base::(anonymous namespace)::ThreadFunc(void*) at ??:? #10: pc 0x7e23f49efc76 sp 0x668d557d4fe0 (libc.so,0x10c76) #11: pc 0x7e23f4a65d19 sp 0x668d557d4ff0 (libc.so,0x86d19) #12: pc 0 sp 0x668d557d5000
,
Feb 21 2018
+rockot: The use of RunLoop() + QuitCurrentWhenIdleDeprecated() seems a little suspect - based on the log output I don't think we're reaching WaitForChildren() in the hang case, so could we be managing to process the OnQuit() on the filter thread before we have actually created and Run() the RunLoop?
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ebb95d13d0646b979ee3de11821c7a5887d0edc commit 6ebb95d13d0646b979ee3de11821c7a5887d0edc Author: Wez <wez@chromium.org> Date: Wed Feb 21 03:31:29 2018 Extend filtering of IpcChannelProxyTest.*MessageClassFilters tests. Bug: 764015 TBR: scottmg Change-Id: Ic9581c33033566b4ccf2bdbc2f70faa37800c7f7 Reviewed-on: https://chromium-review.googlesource.com/927615 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#538014} [modify] https://crrev.com/6ebb95d13d0646b979ee3de11821c7a5887d0edc/testing/buildbot/filters/fuchsia.ipc_tests.filter
,
Feb 26 2018
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d95d4804ffb0644c2bdc32a1b890a9473b45be1e commit d95d4804ffb0644c2bdc32a1b890a9473b45be1e Author: Wez <wez@chromium.org> Date: Mon Feb 26 20:50:47 2018 Add OnChannelError() handler to QuitListener rather than hang on close. Without an OnChannelError() handler on the QuitListener, the test can hang if the IPC channel disconnects before the Quit message is received. Adding an explicit handler will make it easier to diagnose this failure mode. Also migrates DCHECK()s in some existing OnChannelError() handlers in tests to use CHECK(), to avoid those tests potentially hanging in Release builds. Bug: 816606 , 816620 , 764015 Change-Id: Ibe6ffc7ecd02f6029c74a7b3c1190030b656056f Reviewed-on: https://chromium-review.googlesource.com/936427 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539262} [modify] https://crrev.com/d95d4804ffb0644c2bdc32a1b890a9473b45be1e/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/d95d4804ffb0644c2bdc32a1b890a9473b45be1e/ipc/ipc_channel_proxy_unittest.cc
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a84b3ed1c97d1fad1ebf401dc937e806cc895b7 commit 6a84b3ed1c97d1fad1ebf401dc937e806cc895b7 Author: Wez <wez@chromium.org> Date: Tue Mar 13 00:16:23 2018 Un-filter some Mojo and IPC tests under Fuchsia. These tests were flakey due to messages being dropped by the receiver occasionally when the underlying plaform-specific Channel was closed. Bug: 764015 , 764018 , 756112 , 810448 , 815314 , 816620 Change-Id: I2b6cfb105660a570c09b29555da7811541d49ec9 Reviewed-on: https://chromium-review.googlesource.com/959674 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542661} [modify] https://crrev.com/6a84b3ed1c97d1fad1ebf401dc937e806cc895b7/testing/buildbot/filters/fuchsia.ipc_tests.filter [modify] https://crrev.com/6a84b3ed1c97d1fad1ebf401dc937e806cc895b7/testing/buildbot/filters/fuchsia.mojo_unittests.filter |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Feb 16 2018