Issue metadata
Sign in to add a comment
|
iOS context menu to select and copy text is not displayed on long tap |
||||||||||||||||||||
Issue descriptionApp Version: 62.0.3202.16 beta iOS Version: 10.3.3, 11.0 beta#10 Device: iPhone, iPad URL: wikipedia.org/ any Steps to reproduce: 1. Launch Google Chrome 2. Navigate to wikipedia.org and open any article 3. Long tap on any text Observed results: iOS Context menu is not displayed with options to select, copy text Good Version: M62.0.3195.0 #6806c55 Bad Version: M62.0.3196.0 #ee1e477 Expected results: iOS context menu should be displayed to select and copy text Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M61 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M62 Yes Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKubFBWeDBHVDNWN2c/view
,
Sep 12 2017
Culprit is: https://chromium-review.googlesource.com/628576. The point of breaking CL was to fix context menu for iOS 11, so reverting that CL is not a solution. Will look for possible fixes, which can be landed on top.
,
Sep 12 2017
Fix: https://chromium-review.googlesource.com/c/chromium/src/+/663780
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdaaebe87184d49b49de78b006ea79ef49f14afd commit fdaaebe87184d49b49de78b006ea79ef49f14afd Author: Eugene But <eugenebut@google.com> Date: Tue Sep 12 18:43:34 2017 Do not cancel system long press gesture if it's not a link press. Cancelling system long press gesture cancels all system UI (selection and context menu). Cancelling system context menu UI is intentional, because Chrome want to show own context menu. Cancelling system selection UI was a bug. Bug: 763985 Change-Id: I19fb9b7a90948a2ae9151028d4b7bff53e65b0cf Reviewed-on: https://chromium-review.googlesource.com/663780 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501343} [modify] https://crrev.com/fdaaebe87184d49b49de78b006ea79ef49f14afd/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Sep 12 2017
,
Sep 13 2017
Merge approved upon verification of the fix on trunk before merging and on branch 3202 after merging.
,
Sep 14 2017
Context menu is displayed correctly when selecting the text. Verified on M63.0.3216.0 Canary Device: iPhone7 plus, iPhone6 plus iOS: 11.0 GM seed, 10.3.3
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99b006a645fba3d10c47b59aa891cda10a25f49c commit 99b006a645fba3d10c47b59aa891cda10a25f49c Author: Eugene But <eugenebut@google.com> Date: Thu Sep 14 22:41:28 2017 Do not cancel system long press gesture if it's not a link press. Cancelling system long press gesture cancels all system UI (selection and context menu). Cancelling system context menu UI is intentional, because Chrome want to show own context menu. Cancelling system selection UI was a bug. TBR=eugenebut@google.com (cherry picked from commit fdaaebe87184d49b49de78b006ea79ef49f14afd) Bug: 763985 Change-Id: I19fb9b7a90948a2ae9151028d4b7bff53e65b0cf Reviewed-on: https://chromium-review.googlesource.com/663780 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501343} Reviewed-on: https://chromium-review.googlesource.com/668070 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#238} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/99b006a645fba3d10c47b59aa891cda10a25f49c/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Sep 20 2017
Verified in: App Version: 62.0.3202.29 beta Devices: iPhone 5, iPhone 7 Plus, iPad Air iOS Versions: 103.3, 11.0 Selection menu is displayed when selecting the text and Context menu is displayed for link press. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pkl@chromium.org
, Sep 11 2017Labels: -Pri-2 ReleaseBlock-Stable M-62 Pri-1
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)