New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763983 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Rerun argument dropped from dtpr pipeline

Project Member Reported by wylieb@chromium.org, Sep 11 2017

Issue description

Rerun is dropped when calling into child pipelines. Make it a required argument to fix this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/153bea84f73ed4872e1a944f9ca7406d7860a80a

commit 153bea84f73ed4872e1a944f9ca7406d7860a80a
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Sep 15 17:07:51 2017

[Findit] Flake Analyzer - Rerun dropped from dtpr pipeline.

dtpr pipeline isn't passing this parameter to its child pipelines or
recursive calls to itself. Making this argument required for this
pipeline and analyzeflakeforbuildnumber pipeline to fix this.

Bug:  763983 
Change-Id: Ie774ec33a7f500af1f17fec63cc6d921e6012146
Reviewed-on: https://chromium-review.googlesource.com/660977
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/153bea84f73ed4872e1a944f9ca7406d7860a80a/appengine/findit/waterfall/flake/test/analyze_flake_for_build_number_pipeline_test.py
[modify] https://crrev.com/153bea84f73ed4872e1a944f9ca7406d7860a80a/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/153bea84f73ed4872e1a944f9ca7406d7860a80a/appengine/findit/waterfall/flake/determine_true_pass_rate_pipeline.py
[modify] https://crrev.com/153bea84f73ed4872e1a944f9ca7406d7860a80a/appengine/findit/waterfall/flake/analyze_flake_for_build_number_pipeline.py

Comment 2 by wylieb@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment