Tracking bug for various CLs related to this effort.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e1f84a080a2adef81840f65f0ef191fd849ed2 commit d3e1f84a080a2adef81840f65f0ef191fd849ed2 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Sep 12 01:18:50 2017 Fix //third_party/WebKit/PRESUBMIT_test.py so it runs. Also documents that the python-mock backport needs to be installed and formats the file with format-webkitpy. Bug: 763980 Change-Id: I1f629673ce550adc17eacea098cf71e7d6be9436 Reviewed-on: https://chromium-review.googlesource.com/660978 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501139} [modify] https://crrev.com/d3e1f84a080a2adef81840f65f0ef191fd849ed2/third_party/WebKit/PRESUBMIT_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/264a447d211f976348561dfea7cb1fd786d2b4a5 commit 264a447d211f976348561dfea7cb1fd786d2b4a5 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Sep 28 22:17:59 2017 Add tests for enforcing C++ dependencies in PRESUBMIT This CL omits tests for directories where dependencies aren't checked: PRESUBMIT test mocks is missing support for FileSourceFilter. This will be added to test mocks along with the missing tests in a followup CL. Bug: 763980 Change-Id: Ibf9265911f32d24f446e690d9ec05ddb7a61f198 Reviewed-on: https://chromium-review.googlesource.com/671812 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505189} [modify] https://crrev.com/264a447d211f976348561dfea7cb1fd786d2b4a5/PRESUBMIT_test_mocks.py [modify] https://crrev.com/264a447d211f976348561dfea7cb1fd786d2b4a5/third_party/WebKit/PRESUBMIT.py [modify] https://crrev.com/264a447d211f976348561dfea7cb1fd786d2b4a5/third_party/WebKit/PRESUBMIT_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bc8d05039f08647c696e63b0b795189bd1a3917 commit 9bc8d05039f08647c696e63b0b795189bd1a3917 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Oct 20 04:04:35 2017 Add helper for finding use of non-Blink constructs from Blink code. The current presubmit uses fixed set of namespaces to check for disallowed usage of non-Blink constructs from Blink code. The new helper generalizes the check by attempting to find all identifiers qualified with a namespace name. It uses a simple heuristic for doing so: it assumes that namespace names only contain lowercase letters, numbers, and underscores, following the Google C++ style guide convention. This is to avoid accidentally matching against :: that are simply qualifying with the class name. While this does not catch identifiers with no namespace qualifier or identifiers in a namespaces letters (such as WTF), in practice, this is probably good enough. Bug: 763980 Change-Id: Ibc01d5d06a59dd831f52362945cc187bd0329624 Reviewed-on: https://chromium-review.googlesource.com/717947 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510327} [add] https://crrev.com/9bc8d05039f08647c696e63b0b795189bd1a3917/third_party/WebKit/Tools/Scripts/OWNERS [add] https://crrev.com/9bc8d05039f08647c696e63b0b795189bd1a3917/third_party/WebKit/Tools/Scripts/audit-non-blink-usage [modify] https://crrev.com/9bc8d05039f08647c696e63b0b795189bd1a3917/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22f989e96fbd5e7c688ff1a1a81aa6c3a9226c87 commit 22f989e96fbd5e7c688ff1a1a81aa6c3a9226c87 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Nov 10 23:39:36 2017 Blink PRESUBMIT: Switch dependency check to use audit-non-blink-usage Bug: 763980 Change-Id: Ib0598e788a11995d1eb31cda4c3fe13c5a425103 Reviewed-on: https://chromium-review.googlesource.com/763168 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515744} [modify] https://crrev.com/22f989e96fbd5e7c688ff1a1a81aa6c3a9226c87/third_party/WebKit/PRESUBMIT.py [modify] https://crrev.com/22f989e96fbd5e7c688ff1a1a81aa6c3a9226c87/third_party/WebKit/PRESUBMIT_test.py [modify] https://crrev.com/22f989e96fbd5e7c688ff1a1a81aa6c3a9226c87/third_party/WebKit/Tools/Scripts/audit-non-blink-usage
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6a37b738f03e8d0dbd808cc6763cf6f7156f114 commit c6a37b738f03e8d0dbd808cc6763cf6f7156f114 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Nov 24 01:23:38 2017 Remove WTF debug helpers in favor of //base/debug. Bug: 763980 Change-Id: Iacd57a68179023d3669b90f73f549799ab4842b7 Reviewed-on: https://chromium-review.googlesource.com/784551 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#519041} [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/DEPS [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/fonts/FontCache.cpp [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/heap/DEPS [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/scheduler/DEPS [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/testing/DEPS [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/wtf/BUILD.gn [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Source/platform/wtf/DEPS [delete] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/third_party/WebKit/Source/platform/wtf/debug/Alias.h [delete] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/third_party/WebKit/Source/platform/wtf/debug/CrashLogging.h [delete] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/third_party/WebKit/Source/platform/wtf/debug/DEPS [delete] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/third_party/WebKit/Source/platform/wtf/debug/DumpWithoutCrashing.h [delete] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/third_party/WebKit/Source/platform/wtf/debug/StackTrace.h [modify] https://crrev.com/c6a37b738f03e8d0dbd808cc6763cf6f7156f114/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a785272343989e7961abfadd9421e532b428fbb commit 9a785272343989e7961abfadd9421e532b428fbb Author: Klaus Weidner <klausw@chromium.org> Date: Tue Dec 05 08:00:40 2017 Add exceptions for gfx/gpu interfaces used by WebVR The WebKit/Source/modules/vr/ code uses gfx::GpuMemoryBufferHandle and gpu::MailboxHolder for transferring frame images, these symbols shouldn't block presubmit checks. BUG=763980 Change-Id: I2f9fdd173f0173bdb51337d3943b590f42550528 Reviewed-on: https://chromium-review.googlesource.com/804742 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521636} [modify] https://crrev.com/9a785272343989e7961abfadd9421e532b428fbb/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b7899fd8988c84da19c5d755fdea5ae14c1ea15 commit 3b7899fd8988c84da19c5d755fdea5ae14c1ea15 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Dec 05 23:42:07 2017 Add OWNERS files for third_party/WebKit/Source/DEPS Bug: 763980 Change-Id: Ic7f5e4c37293767c3fb38c345880f2a07e053385 Reviewed-on: https://chromium-review.googlesource.com/808747 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521899} [add] https://crrev.com/3b7899fd8988c84da19c5d755fdea5ae14c1ea15/third_party/WebKit/Source/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7415aba925967876af5ec81fd2e6c8f5522265ab commit 7415aba925967876af5ec81fd2e6c8f5522265ab Author: Yuta Kitamura <yutak@chromium.org> Date: Thu Dec 07 06:33:24 2017 Allow base callbacks everywhere in Blink. We are now mostly ready to start replacing WTF::Function with base callbacks. This patch updates DEPS and audit-non-blink-usage.py so we can use base callback stuff in Blink. Bug: 771087 , 763980 Change-Id: I8b41ab2c3e9e72279039685960b6dd1b558ee457 Reviewed-on: https://chromium-review.googlesource.com/807754 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522367} [modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Source/DEPS [modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Source/platform/DEPS [modify] https://crrev.com/7415aba925967876af5ec81fd2e6c8f5522265ab/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cfad382b73e7240cf6803d28446ba99b14c5b1d commit 6cfad382b73e7240cf6803d28446ba99b14c5b1d Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Dec 15 10:56:09 2017 Replace WTF::TimeTicks::Now() with WTF::CurrentTimeTicks(). This allows mocking of TimeTicks inside Blink once WTF::TimeTicks is merged into base::TimeTicks. base::TimeTicks::Now() will be explicitly disallowed in Blink to ensure that there is a consistent global view of the mocked time ticks. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I356da09d27694c4d4323a8b494a2afef6a80baf3 Reviewed-on: https://chromium-review.googlesource.com/827545 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524356} [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/animation/AnimationClock.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/animation/PendingAnimations.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/css/StyleSheetContents.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/DocumentTiming.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/IdleDeadline.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/PendingScript.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/events/Event.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/events/Event.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/dom/events/EventTarget.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/CompositionEvent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/FocusEvent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/MouseEvent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/MouseEvent.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/PointerEvent.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/TextEvent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/UIEvent.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/events/UIEventWithKeyState.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/exported/WebFrameTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/exported/WebViewImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/frame/FrameSerializer.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/frame/History.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/frame/UserActivationState.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/html/parser/PreloadRequest.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/EventHandlerTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/GestureManager.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/MouseEventManager.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/OverscrollBehaviorTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/input/ScrollSnapTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/IdlenessDetector.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/InteractiveDetector.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/page/AutoscrollController.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/page/AutoscrollControllerTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/page/DragController.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/paint/PaintTiming.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/timing/MemoryInfo.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/timing/PerformanceBase.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/timing/PerformanceTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/document_metadata/CopylessPasteExtractor.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuListElement.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineMetrics.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/modules/webdatabase/Database.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/Histogram.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/HistogramTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/LongTaskDetectorTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/Timer.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/Timer.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/TimerTest.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/bindings/ScriptWrappableVisitor.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/graphics/ProfilingCanvas.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/heap/Heap.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/heap/HeapCompact.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/heap/ThreadState.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/probe/PlatformProbes.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h [add] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/testing/wtf/ScopedMockClock.cpp [add] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/testing/wtf/ScopedMockClock.h [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/wtf/Time.cpp [modify] https://crrev.com/6cfad382b73e7240cf6803d28446ba99b14c5b1d/third_party/WebKit/Source/platform/wtf/Time.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76341608ab75fed6fd808e1cba17f8934a41b1b commit a76341608ab75fed6fd808e1cba17f8934a41b1b Author: Yuta Kitamura <yutak@chromium.org> Date: Thu Jan 25 07:36:01 2018 Allow base::{Time,TimeDelta,TimeTicks} in Blink. As of crrev.com/531516, all of the WTF counterparts of those base classes are now simple aliases to the base ones. Now, we can start using the base classes in Blink. Bug: 763980, 794845 Change-Id: Ica8d81549ed6d7fd4f56ed03d22562c973e8a00e Reviewed-on: https://chromium-review.googlesource.com/886041 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531841} [modify] https://crrev.com/a76341608ab75fed6fd808e1cba17f8934a41b1b/third_party/WebKit/Source/DEPS [modify] https://crrev.com/a76341608ab75fed6fd808e1cba17f8934a41b1b/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4e3de1eb4aa66fe3aea82037595ee62a435f44c commit c4e3de1eb4aa66fe3aea82037595ee62a435f44c Author: Yuta Kitamura <yutak@chromium.org> Date: Fri Jan 26 23:46:42 2018 Allow #include of base/single_thread_task_runner.h in Blink. The use of base::SingleThreadTaskRunner is already allowed according to audit-non-blink-usage.py, but #include of the header was not allowed except in Source/platform/. This patch allows the include in the other places of Source/. base::SingleThreadTaskRunner will be used much more frequently in Blink, after we finish the conversion of WebTaskRunner. This change prepares for it. Bug: 763980, 794845 Change-Id: Iab0ed63f23efdfcb05df0b219bbed98e53f36f9c Reviewed-on: https://chromium-review.googlesource.com/888300 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532093} [modify] https://crrev.com/c4e3de1eb4aa66fe3aea82037595ee62a435f44c/third_party/WebKit/Source/DEPS [modify] https://crrev.com/c4e3de1eb4aa66fe3aea82037595ee62a435f44c/third_party/WebKit/Source/platform/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e51d8e83f2d6bfc157b9f9411cd668051050931 commit 2e51d8e83f2d6bfc157b9f9411cd668051050931 Author: Fergal Daly <fergal@chromium.org> Date: Tue Jan 30 05:18:17 2018 Remove base::OnceCallback<void()> from disallow_list. It was added to the whitelist in https://crrev.com/c/807754. Bug: 771087 ,763980 Change-Id: I3f168415bba5cfcf4383c30c3ef6e66036ffc050 Reviewed-on: https://chromium-review.googlesource.com/892195 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532768} [modify] https://crrev.com/2e51d8e83f2d6bfc157b9f9411cd668051050931/third_party/WebKit/PRESUBMIT_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93c80a9335c4357a5f30139c74db78a358f6231f commit 93c80a9335c4357a5f30139c74db78a358f6231f Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Feb 14 19:02:43 2018 Change WebInputEvent::kTimeStampForTesting to be a function. WebInputEvent's timestamp will change to a base::TimeTicks in a followup CL, so the test timestamp's type will change as well. Normally, this would be easy: the followup patch would simply change the type of kTimeStampForTesting to base::TimeTicks. However, changing the type means that kTimeStampForTesting is considered ODR-used when passed as a direct argument to EXPECT_EQ, and thus requires a definition. Pre-C++17, this definition must be out-of-line. However, that means WebInputEvent is no longer a header-only class, which means all consumers of this header must link against Blink itself. This is undesirable, since WebInputEvent is also used from the browser process, which should not link against Blink. To workaround all of this, change it to a helper function which is inline in the header and won't suffer from the ODR-use issues with googletest. TBR=jam@chromium.org Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic6f3b31f2abf747af70f7c96d9f44a5151265582 Reviewed-on: https://chromium-review.googlesource.com/917335 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536767} [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/chrome_site_per_process_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/chromeos/input_method/textinput_test_helper.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/pdf/pdf_extension_test.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/referrer_policy_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/ui/cocoa/browser_window_utils_unittest.mm [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/ui/cocoa/tab_contents/web_contents_view_mac_interactive_uitest.mm [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/components/printing/test/print_render_frame_helper_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/pointer_lock_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/site_per_process_mac_browsertest.mm [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/browser/web_contents/web_contents_view_aura_browsertest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/common/input/input_param_traits_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/common/input/touch_event_stream_validator_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/content/renderer/input/main_thread_event_queue_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/editing/KeyboardTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/exported/WebFrameTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/exported/WebViewTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/frame/BrowserControlsTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/input/EventHandlerTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/input/ImeOnFocusTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/page/DragControllerTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/page/EffectiveNavigationPolicyTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/third_party/WebKit/public/platform/WebInputEvent.h [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/ui/events/blink/blink_event_util_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/ui/events/blink/input_handler_proxy_unittest.cc [modify] https://crrev.com/93c80a9335c4357a5f30139c74db78a358f6231f/ui/events/blink/web_input_event_traits_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/224569ee2424ddae2ad63294e154fdee182192eb commit 224569ee2424ddae2ad63294e154fdee182192eb Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Apr 25 05:45:06 2018 Change blink::WebInputEvent timestamp from double to base::TimeTicks. Using a double timestamp is prone to errors, since nothing stops a numerical quantity with the wrong units from being passed in (or even worse... random unscoped enumerators). Instead, just use base::TimeTicks directly in blink::WebInputEvent: this allows all the conversions between base::TimeTicks and doubles to be removed and ensures better type-safety throughout the code. Several methods in the Blink public API have also been converted to pass time as base::TimeTicks, though those changes are limited to avoid changing the entire codebase in one CL. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I258486006302d010b121b39628ca3e8b3d71491f Reviewed-on: https://chromium-review.googlesource.com/793050 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553460} [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/base/time/time.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/android/vr/android_ui_gesture_target.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/android/vr/vr_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/android/vr/vr_dialog.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/page_load_metrics/user_input_tracker.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/page_load_metrics/user_input_tracker.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/page_load_metrics/user_input_tracker_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/ui/browser_command_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/components/autofill/content/browser/key_press_handler_manager_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/components/sync_sessions/local_session_event_handler_impl_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/android/ime_adapter_android.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/android/overscroll_controller_android_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/compositor_event_ack_browsertest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/fling_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/fling_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/motion_event_web.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/mouse_wheel_phase_handler.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/passthrough_touch_event_queue.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_gesture_target_android.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_gesture_target_android.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_mouse_driver.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_pointer_driver.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_pointer_driver.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/synthetic_touch_driver.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/touch_emulator.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/touch_emulator.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/touch_emulator_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/web_input_event_builders_android.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/web_input_event_builders_android.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/web_input_event_builders_android_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/input/web_input_event_util_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/native_web_keyboard_event_android.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/native_web_keyboard_event_aura.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/native_web_keyboard_event_mac.mm [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/overscroll_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/overscroll_controller.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/overscroll_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/render_widget_host_view_cocoa.mm [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/renderer_host/ui_events_helper.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/browser/web_contents/web_contents_view_aura_browsertest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/content_param_traits.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/event_with_latency_info.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/event_with_latency_info_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/input_event_struct_traits.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/input_event_struct_traits.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/input_handler.mojom [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/synthetic_web_input_event_builders.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/web_touch_event_traits.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/input/web_touch_event_traits.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/common/view_messages.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/public/browser/native_web_keyboard_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/public/test/browser_test_utils.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/public/test/render_view_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/gpu/render_widget_compositor_delegate.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/gpu/render_widget_compositor_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/input/render_widget_input_handler.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/input/scoped_web_input_event_with_latency_info.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/input/widget_input_handler_manager.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/pepper/event_conversion.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_frame_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_view_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_view_impl.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_widget.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_widget.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_widget_fullscreen_pepper.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/renderer/render_widget_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/shell/test_runner/event_sender.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/shell/test_runner/event_sender.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/content/shell/test_runner/text_input_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_gesture_curve.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_gesture_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_input_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_keyboard_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_mouse_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_mouse_wheel_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_pointer_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/platform/web_touch_event.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/web/web_active_fling_parameters.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/web/web_view.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/public/web/web_widget.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/animation/compositor_animations_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/dom/node.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/gesture_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/keyboard_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/pointer_event_factory.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/pointer_event_factory_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/touch_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/touch_event_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/web_input_event_conversion.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/events/wheel_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_page_popup_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_page_popup_impl.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_view_impl.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/exported/web_view_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/browser_controls_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_frame_widget_base.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_frame_widget_base.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_frame_widget_impl.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_view_frame_widget.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/frame/web_view_frame_widget.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/html/forms/type_ahead_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/event_handler.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/event_handler_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/gesture_manager.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/mouse_event_manager.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/overscroll_behavior_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/pointer_event_manager.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/pointer_event_manager_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/scroll_snap_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/input/touch_event_manager.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/layout/scrollbars_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/loader/interactive_detector.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/loader/interactive_detector.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/page/autoscroll_controller_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/page/drag_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/page/scrolling/scroll_metrics_test.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/testing/sim/sim_compositor.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/core/testing/sim/sim_compositor.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/platform/exported/web_active_gesture_animation.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/platform/exported/web_active_gesture_animation.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/platform/web_mouse_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/platform/web_pointer_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/third_party/blink/renderer/platform/wtf/time.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/blink_event_util.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/event_with_callback.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/fling_booster.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/fling_booster.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/fling_booster_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/input_handler_proxy.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/input_handler_proxy_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/input_scroll_elasticity_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/input_scroll_elasticity_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/snap_fling_controller.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/snap_fling_controller_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event_builders_win.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event_builders_win.h [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event_builders_win_unittest.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/224569ee2424ddae2ad63294e154fdee182192eb/ui/events/blink/web_input_event_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/914837266739366e49adda8275450383ddebd607 commit 914837266739366e49adda8275450383ddebd607 Author: Stephen McGruer <smcgruer@chromium.org> Date: Fri Apr 27 17:14:34 2018 Plumb base::TimeTicks down into ScriptedAnimationController::ServiceScriptedAnimations Using a double timestamp is prone to errors, since nothing stops a numerical quantity with the wrong units from being passed in. This CL is part of a series to make more time interactions in Blink saner. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2b0d6ee0b43a63a6af44352f929f57fc6d0cf82a Reviewed-on: https://chromium-review.googlesource.com/1030908 Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554411} [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/dom/scripted_animation_controller.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/dom/scripted_animation_controller.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/dom/scripted_animation_controller_test.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/exported/web_page_popup_impl.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/input/event_handler_test.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/autoscroll_controller.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/autoscroll_controller.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/page_animator.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/page_animator.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/page_widget_delegate.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/page/page_widget_delegate.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/svg/graphics/svg_image.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/svg/graphics/svg_image.h [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate_test.cc [modify] https://crrev.com/914837266739366e49adda8275450383ddebd607/third_party/blink/renderer/modules/vr/vr_display.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9b2b9391d69d42996ddb09564f7787218119c47 commit b9b2b9391d69d42996ddb09564f7787218119c47 Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue May 01 13:55:44 2018 Convert blink::AnimationClock to use base::TimeTicks internally Using a double timestamp is prone to errors, since nothing stops a numerical quantity with the wrong units from being passed in. This CL is part of a series to make more time interactions in Blink saner. Bug: 737867, 763980 Change-Id: Id977edb1ad9511ecefadd38610e06f88fda8224e Reviewed-on: https://chromium-review.googlesource.com/1033431 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555032} [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/animation_clock.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/animation_clock.h [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/animation_clock_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/animation_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/compositor_animations_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/document_timeline_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/effect_stack_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/animation/keyframe_effect_test.cc [modify] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/third_party/blink/renderer/core/page/page_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e73234c143d18cf52dc4082318f08d1e6077ea8 commit 8e73234c143d18cf52dc4082318f08d1e6077ea8 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Jun 26 16:20:29 2018 Use base::TimeTicks in FrameSerializer Bug: 763980 Change-Id: I380ce86b5b6ba5bd31fcda2e3b64a74abe9e92a1 Reviewed-on: https://chromium-review.googlesource.com/1112629 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570422} [modify] https://crrev.com/8e73234c143d18cf52dc4082318f08d1e6077ea8/third_party/blink/renderer/core/frame/frame_serializer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83430576932f48c12daa8a4103dda873bd75639f commit 83430576932f48c12daa8a4103dda873bd75639f Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jun 27 16:15:39 2018 Use base::TimeTicks in OffScreenCanvas Using a double timestamp is error prone and it's hard to tell which units are being used. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bb9e1fba0df15be9954cf055abed78016c39c9a Reviewed-on: https://chromium-review.googlesource.com/1114180 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570795} [modify] https://crrev.com/83430576932f48c12daa8a4103dda873bd75639f/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc [modify] https://crrev.com/83430576932f48c12daa8a4103dda873bd75639f/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc [modify] https://crrev.com/83430576932f48c12daa8a4103dda873bd75639f/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc [modify] https://crrev.com/83430576932f48c12daa8a4103dda873bd75639f/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h [modify] https://crrev.com/83430576932f48c12daa8a4103dda873bd75639f/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271f674380fc977caa985752b36bfd98e0d60578 commit 271f674380fc977caa985752b36bfd98e0d60578 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Jun 28 22:01:06 2018 Use TimeTicks and TimeDelta in canvas_async_blob_creator Using double to represent timestamps and time ranges is error prone and the units used are unclear. Bug: 763980 Change-Id: I80ff8c1f0eb8d575e00b0edbce1dd8bbaec0ca7e Reviewed-on: https://chromium-review.googlesource.com/1112566 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571287} [modify] https://crrev.com/271f674380fc977caa985752b36bfd98e0d60578/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc [modify] https://crrev.com/271f674380fc977caa985752b36bfd98e0d60578/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h [modify] https://crrev.com/271f674380fc977caa985752b36bfd98e0d60578/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc [modify] https://crrev.com/271f674380fc977caa985752b36bfd98e0d60578/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc [modify] https://crrev.com/271f674380fc977caa985752b36bfd98e0d60578/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9fe54cc4e7dbf24d3e7696f8d260a546e708214 commit c9fe54cc4e7dbf24d3e7696f8d260a546e708214 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Jul 04 17:24:40 2018 Use TimeDelta in PausableTimer Mostly s/double/TimeDelta/ and Method() to MethodDelta(). The kNextFireIntervalInvalid constant is changed to TimeDelta::Min(). Bug: 763980 Change-Id: I878a4136edcfe815184e7021a19eefffbc02fd31 Reviewed-on: https://chromium-review.googlesource.com/1125919 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#572612} [modify] https://crrev.com/c9fe54cc4e7dbf24d3e7696f8d260a546e708214/third_party/blink/renderer/core/frame/pausable_timer.cc [modify] https://crrev.com/c9fe54cc4e7dbf24d3e7696f8d260a546e708214/third_party/blink/renderer/core/frame/pausable_timer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2870f25fdac89319f768a3af55b7541c309cac94 commit 2870f25fdac89319f768a3af55b7541c309cac94 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Jul 04 19:05:43 2018 Replace uses of RepeatInterval() in DOMTimer with RepeatIntervalDelta() RepeatInterval() is used in DOMTimer::Stop and DOMTimer::Fired to determine if the timer is an interval timer or not. This can trivially use the TimeDelta version instead. Also use g_null_atom to pass a null AtomicString, rather than creating a temporary. Bug: 763980 Change-Id: I7b191ab7b99d22f73974b7b448b059c2f8cb51ef Reviewed-on: https://chromium-review.googlesource.com/1125930 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#572631} [modify] https://crrev.com/2870f25fdac89319f768a3af55b7541c309cac94/third_party/blink/renderer/core/frame/dom_timer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d2294665a71189cf92eaabca687eb26ba29aeac commit 0d2294665a71189cf92eaabca687eb26ba29aeac Author: Fredrik Söderquist <fs@opera.com> Date: Fri Jul 06 14:49:44 2018 Use TimeDelta in media controls/PiP Straightforward double -> TimeDelta conversion. Names of constants have been changed to remove any unit (like "...Seconds") - often replaced by "...Duration". "Trans" was also expanded to "Transition" in a few places. Bug: 763980 Change-Id: I1b193ecf338245c5873f002c0cfcd1b679b345d7 Reviewed-on: https://chromium-review.googlesource.com/1127782 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#572971} [modify] https://crrev.com/0d2294665a71189cf92eaabca687eb26ba29aeac/third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.cc [modify] https://crrev.com/0d2294665a71189cf92eaabca687eb26ba29aeac/third_party/blink/renderer/core/html/media/media_remoting_interstitial.cc [modify] https://crrev.com/0d2294665a71189cf92eaabca687eb26ba29aeac/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc [modify] https://crrev.com/0d2294665a71189cf92eaabca687eb26ba29aeac/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c9e24d438287cb93f2b050b372c82f789271130 commit 4c9e24d438287cb93f2b050b372c82f789271130 Author: Fredrik Söderquist <fs@opera.com> Date: Mon Jul 09 12:22:16 2018 Use TimeDelta in Scrollbar/ScrollableArea/ScrollbarTheme Straightforward conversion in Scrollbar and ScrollableArea. In ScrollbarTheme, OverlayScrollbarFadeOutDelaySeconds, OverlayScrollbarFadeOutDurationSeconds, InitialAutoscrollTimerDelay and AutoscrollTimerDelay are changed to return TimeDelta. The "Seconds" suffix is dropped from the two earlier methods. Bug: 763980 Change-Id: Idf1a8b1e44db18427db7a9acebd09f63be2c4cdc Reviewed-on: https://chromium-review.googlesource.com/1127781 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573274} [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/content/child/webthemeengine_impl_android.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/content/child/webthemeengine_impl_default.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/public/platform/web_theme_engine.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/core/layout/layout_scrollbar_theme.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/core/layout/scrollbars_test.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollable_area.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollable_area_test.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.mm [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay.cc [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay.h [modify] https://crrev.com/4c9e24d438287cb93f2b050b372c82f789271130/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay_mock.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8 commit 39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8 Author: Fredrik Söderquist <fs@opera.com> Date: Mon Jul 09 13:48:25 2018 Use Time{Delta,Ticks} in LayoutProgress Make |animation_start_time_| TimeTicks and |animation_repeat_interval_| and |animation_duration_| TimeDelta to match semantics. Update AnimationDurationForProgressBar and AnimationRepeatIntervalForProgressBar in LayoutTheme to return TimeDelta. Bug: 763980 Change-Id: I3134116861dce6bdf0be050870cba25b0ef56e68 Reviewed-on: https://chromium-review.googlesource.com/1127780 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#573291} [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_progress.cc [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_progress.h [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme.cc [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme.h [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme_default.cc [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme_default.h [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme_mac.h [modify] https://crrev.com/39bf67ff6dd2e6e5bf2ff1efb75b06376a339ed8/third_party/blink/renderer/core/layout/layout_theme_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8c107089394302ca84e7dd536c3eb937e38904f commit f8c107089394302ca84e7dd536c3eb937e38904f Author: Fredrik Söderquist <fs@opera.com> Date: Mon Jul 09 14:21:28 2018 Use TimeDelta in FirstMeaningfulPaintDetector This changes the |network2_quiet_window_seconds_| and |network0_quiet_window_seconds_| fields from double to TimeDelta, renaming them to not have 'seconds' in the name (replaced by 'timeout'.) Adjust the unit test, and replace AdvanceClockSeconds with AdvanceClock throughout. Add a new TestingPlatformSupportWithMockScheduler::RunForPeriod, mimicking the setup for AdvanceClock{,Seconds}. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9316759a30c6fbe3fb4d7ea15106d6c47366ba33 Reviewed-on: https://chromium-review.googlesource.com/1127779 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#573298} [modify] https://crrev.com/f8c107089394302ca84e7dd536c3eb937e38904f/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.cc [modify] https://crrev.com/f8c107089394302ca84e7dd536c3eb937e38904f/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.h [modify] https://crrev.com/f8c107089394302ca84e7dd536c3eb937e38904f/third_party/blink/renderer/core/paint/first_meaningful_paint_detector_test.cc [modify] https://crrev.com/f8c107089394302ca84e7dd536c3eb937e38904f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc [modify] https://crrev.com/f8c107089394302ca84e7dd536c3eb937e38904f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f383d6848fa4566ef1a5e754481428c9a24d42a commit 1f383d6848fa4566ef1a5e754481428c9a24d42a Author: Fredrik Söderquist <fs@opera.com> Date: Mon Jul 09 17:51:22 2018 Use TimeDelta for a bunch of timer durations/timeouts Most of these changes are of the (int|unsigned|double) -> TimeDelta type. In a few cases (EventSource, GeoNotifier, VibrationController), an invocation of StartOneShot(double, ...) is changed to a StartOneShot(TimeDelta, ...) with an appropriate TimeDelta::From... conversion (all for milliseconds even.) In some cases names of constants are changed to remove the unit, since that's no longer meaningful. EventHandler::TargetGestureEvent was doing an unnecessary conversion, so just drop that. Remove the GeoNotifier::Timer::StartOneShot(double, ...) overload since it's no longer used. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5b117500db400da60faba0e308bc1644c26992d Reviewed-on: https://chromium-review.googlesource.com/1127785 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#573359} [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_callback.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/frame/local_dom_window.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/input/event_handler.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/input/mouse_event_manager.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/layout/jank_tracker.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/page/validation_message_client_impl.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/svg/animation/smil_time_container.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/eventsource/event_source.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/geolocation/geo_notifier.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/geolocation/geo_notifier.h [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/payments/payment_request.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/payments/payment_request_update_event.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/serviceworkers/wait_until_observer.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/vibration/vibration_controller.cc [modify] https://crrev.com/1f383d6848fa4566ef1a5e754481428c9a24d42a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e9abea222d69448caf92ea7062982ec3a8337a8 commit 6e9abea222d69448caf92ea7062982ec3a8337a8 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Jul 11 11:49:28 2018 Remove the 'double' methods from blink::TimerBase Remove the methods in blink::TimerBase that either take or return a time delta as a double. These methods are mostly unused - a few calls to StartOneShot and NextFireInterval, and it should be preferable for new code to use the TimeDelta methods. The non-Delta-suffixed names are kept - i.e they take on the name of their removed equivalent where applicable. The few users of StartOneShot(double, ...) are open-coded instead, and uses of other methods are adjusted as needed. The unit tests for Timer is overhauled to use TimeTicks and TimeDelta throughout. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47c0449a9ea68e6e984c371e19f03f747bb5b1e0 Reviewed-on: https://chromium-review.googlesource.com/1131131 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574127} [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/animation/document_timeline.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/frame/dom_timer.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/frame/pausable_timer.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/html/forms/search_input_type.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/layout/layout_text.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/svg/animation/smil_time_container.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/core/svg/graphics/svg_image_test.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/platform/timer.cc [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/platform/timer.h [modify] https://crrev.com/6e9abea222d69448caf92ea7062982ec3a8337a8/third_party/blink/renderer/platform/timer_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64466bc6473bfe06eb1f398531c148a6f4d11fec commit 64466bc6473bfe06eb1f398531c148a6f4d11fec Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Jul 17 17:54:36 2018 Use TimeTicks/TimeDelta in interactive_detector_test.cc Changes methods in this test to use TimeTicks instead of double to represent timestamps. Change-Id: Ib888cd0d107e2190d7216ee0e69fea02c34ea78d Bug: 763980 Reviewed-on: https://chromium-review.googlesource.com/1117829 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#575712} [modify] https://crrev.com/64466bc6473bfe06eb1f398531c148a6f4d11fec/third_party/blink/renderer/core/loader/interactive_detector_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08e1cc53a605aa2e57330b887904554b29e05f87 commit 08e1cc53a605aa2e57330b887904554b29e05f87 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Jul 25 16:35:59 2018 Make ScrollOffsetAnimationCurve::UpdateTarget use TimeDelta Makes the method use TimeDelta instead of double to represent duration. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id95aface04fa2b72bc919fd4ab52af062908f8df Bug: 763980 Reviewed-on: https://chromium-review.googlesource.com/1140355 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#577928} [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/cc/animation/scroll_offset_animation_curve.cc [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/cc/animation/scroll_offset_animation_curve.h [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/cc/animation/scroll_offset_animation_curve_unittest.cc [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/cc/animation/scroll_offset_animations_impl.cc [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/third_party/blink/renderer/platform/animation/compositor_scroll_offset_animation_curve.cc [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/third_party/blink/renderer/platform/animation/compositor_scroll_offset_animation_curve.h [modify] https://crrev.com/08e1cc53a605aa2e57330b887904554b29e05f87/third_party/blink/renderer/platform/scroll/scroll_animator.cc
Comment 1 by bugdroid1@chromium.org
, Sep 12 2017