New issue
Advanced search Search tips

Issue 763977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Compiler warning in app_list_view.cc

Project Member Reported by khorimoto@chromium.org, Sep 11 2017

Issue description

In the past few days, I've begun getting this compiler warning whenever building. I'm building Chrome OS for Eve.

Looks to be caused by https://chromium-review.googlesource.com/c/chromium/src/+/643790.

[15700/27994] CXX obj/ui/app_list/app_list/app_list_view.o
../../ui/app_list/views/app_list_view.cc:1072:11: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value]
      if (fabs(offset) > kAppListMinScrollToSwitchStates) {
          ^
../../ui/app_list/views/app_list_view.cc:1072:11: note: use function 'std::abs' instead
      if (fabs(offset) > kAppListMinScrollToSwitchStates) {
          ^~~~
          std::abs
1 warning generated.
 
Status: Fixed (was: Assigned)
Fixed in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/658336

Comment 2 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 3 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment