New issue
Advanced search Search tips

Issue 763966 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

[DeviceMemory] Postpone shipping the DeviceMemory JS API to a later release

Project Member Reported by fmea...@chromium.org, Sep 11 2017

Issue description

We would like to postpone shipping this feature as we build more consensus.

This is bug is for tracking the unshipping from M62.




 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bacf86ba10a26e119006365a040a1aa5ea579c3

commit 7bacf86ba10a26e119006365a040a1aa5ea579c3
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Mon Sep 11 18:29:39 2017

Revert "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.

Reason for revert: Postpone shipping this feature to M63.

Original change's description:
> [DeviceMemory] Ship DeviceMemory JS API
> 
> I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> 
> Bug:  chromium:758302 , chromium:710702 
> Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> Reviewed-on: https://chromium-review.googlesource.com/641392
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498503}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
Reviewed-on: https://chromium-review.googlesource.com/660481
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500982}
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 2 by panicker@google.com, Sep 12 2017

This is a safe change for merging to M62: flips flag for Device memory JS API back to experimental (from stable).
Components: Blink>JavaScript>API
Labels: Merge-Request-62
This CL has landed in 63.0.3213.0 and no reported crashes for it. Requesting Merge.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76cafeff582457d6c20052ffbead439f985bef48

commit 76cafeff582457d6c20052ffbead439f985bef48
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Wed Sep 13 16:12:02 2017

Revert "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.

Reason for revert: Postpone shipping this feature to M63.

Original change's description:
> [DeviceMemory] Ship DeviceMemory JS API
> 
> I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> 
> Bug:  chromium:758302 , chromium:710702 
> Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> Reviewed-on: https://chromium-review.googlesource.com/641392
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498503}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
Reviewed-on: https://chromium-review.googlesource.com/660481
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500982}(cherry picked from commit 7bacf86ba10a26e119006365a040a1aa5ea579c3)
Reviewed-on: https://chromium-review.googlesource.com/665317
Cr-Commit-Position: refs/branch-heads/3202@{#204}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaffb85b56a6da09de221425afdf5320f5038a16

commit aaffb85b56a6da09de221425afdf5320f5038a16
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Thu Oct 12 23:32:38 2017

Reland "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit 7bacf86ba10a26e119006365a040a1aa5ea579c3.

Reason for revert: The API was approved.

Original change's description:
> Revert "[DeviceMemory] Ship DeviceMemory JS API"
> 
> This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.
> 
> Reason for revert: Postpone shipping this feature to M63.
> 
> Original change's description:
> > [DeviceMemory] Ship DeviceMemory JS API
> > 
> > I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> > 
> > Bug:  chromium:758302 , chromium:710702 
> > Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> > Reviewed-on: https://chromium-review.googlesource.com/641392
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> > Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498503}
> 
> TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
> Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
> Reviewed-on: https://chromium-review.googlesource.com/660481
> Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500982}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: I4099ca458088ddfde32e8af43dda26d6cd7045ea
Reviewed-on: https://chromium-review.googlesource.com/716916
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508536}
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Sign in to add a comment