New issue
Advanced search Search tips

Issue 763959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature

Blocking:
issue 757515



Sign in to add a comment

Support filtering code coverage results by build target in code coverage script.

Project Member Reported by liaoyuke@chromium.org, Sep 11 2017

Issue description

The code coverage script should be able to get coverage for the sources in a gn target or set of targets. In ios/clean, the general convention is that UI (view controllers) are in a separate target, and they are mostly tested via egtests in showcase. So when generating coverage numbers for ios/clean, we should exclude the ui targets for unittests, and we should exclude the other targets for the showcase egtests.
 
Summary: Support filtering code coverage results by build target in code coverage script. (was: Support test filter by build target in code coverage script.)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b55b9a83d93cb1071bdfdbc0fd09b2c663cbce2a

commit b55b9a83d93cb1071bdfdbc0fd09b2c663cbce2a
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Sep 19 19:42:25 2017

[Coverage] Support negative filter and filter by build targets.

This CL adds support to the code coverage tool to include files by
build targets and also exclude files by paths or build targets.

The motivation of this change is that some view controllers are not
supposed to have unit tests, and instead, they should run agaist 
integration tests in terms of code coverage. Given that view 
controllers are often grouped together by build targets, so it is 
desirable to have a way to include or exclude the sources of a list
of build targets in the code coverage report.

Bug:  763959 
Change-Id: I68079e0e6e5952883259b8806cb250166d0a50dc
Reviewed-on: https://chromium-review.googlesource.com/669979
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502922}
[modify] https://crrev.com/b55b9a83d93cb1071bdfdbc0fd09b2c663cbce2a/ios/tools/coverage/coverage.py

Status: Fixed (was: Started)

Sign in to add a comment