New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763953 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 770046



Sign in to add a comment

Saved passwords on Android: icons should be grey

Project Member Reported by maxwalker@chromium.org, Sep 11 2017

Issue description

Chrome Version: M62/63 
OS: Android

The copy- and view icons should be grey (black with 54% alpha) instead of blue, like in the Chrome Menu (Android) and Password Manager settings (Desktop).
 
Passwords.png
58.3 KB View Download
Labels: clank-view-copy-passwords
Cc: hannahs@chromium.org
+hannahs - I'm wondering if this should be 54% black. I think we use 65% black for icons now?
+1 I've been trying to promote using 65% grey for icons unless it noticeably affects performance (ie: web UI where we can use the current hex value #5a5a5a).
Also I agree on the Blue text as they're not links. Let's Roboto Regular 14sp 54% black - #8A000000
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d661a14710220d9776c1815638201549198645b

commit 9d661a14710220d9776c1815638201549198645b
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Nov 23 14:37:51 2017

Saved passwords on Android: icons should be grey

This CL changes the icon stored in the repo from blue to black and
makes color of icon in settings grey (black with 54% alpha)

Bug: 763953
Change-Id: I0a49ccd3c7a0f0eddd9b23ae59f5534c03e0ac89
Reviewed-on: https://chromium-review.googlesource.com/668451
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518932}
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-hdpi/ic_content_copy.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-hdpi/ic_visibility.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-hdpi/ic_visibility_off.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-mdpi/ic_content_copy.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-mdpi/ic_visibility.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-mdpi/ic_visibility_off.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xhdpi/ic_content_copy.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xhdpi/ic_visibility.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xhdpi/ic_visibility_off.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxhdpi/ic_content_copy.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxhdpi/ic_visibility.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxhdpi/ic_visibility_off.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxxhdpi/ic_content_copy.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxxhdpi/ic_visibility.png
[delete] https://crrev.com/455713fea621df8df6a0eaef051e8a88de6f5659/chrome/android/java/res/drawable-xxxhdpi/ic_visibility_off.png
[add] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/res/drawable/ic_content_copy_black.xml
[add] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/res/drawable/ic_visibility_black.xml
[add] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/res/drawable/ic_visibility_off_black.xml
[modify] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/9d661a14710220d9776c1815638201549198645b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Comment 6 by kolos@chromium.org, Jan 26 2018

Blocking: 770046
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment