New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763946 link

Starred by 1 user
Status: Fixed
Owner:
mastiz@chromium.org
Closed: Oct 2017
Cc:
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Log age of Chrome Suggestions (staleness)

Project Member Reported by mastiz@chromium.org, Sep 11 2017 
Future changes like Chrome Home are expected to impact the age/staleness of Chrome Suggestions, measured by the time elapsed between their computation (server-side) and the actual client-side impression.

We'd need to instrument UMA to verify nothing breaks.

Comment 1 by fi...@chromium.org, Sep 11 2017

Labels: zine-triaged M-63

Comment 2 by fi...@chromium.org, Oct 9 2017 

ping - M63 BP is around the corner. Did anything happen here?

Comment 3 by mastiz@chromium.org, Oct 9 2017 

Nothing happened but there's still hope, we'll punt otherwise.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0f98cc9956e6a634c846d2450fa68bbfd3769da

commit a0f98cc9956e6a634c846d2450fa68bbfd3769da
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 12 19:48:48 2017

Log UMA metrics with NTP tile data age/staleness

Most notably, we want to capture this metric for server-side suggestions
in order to detect regressions in upcoming UI changes (Chrome Home).

Bug:  763946 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4cb7e6cea6026ad33182f70d7434ab59f7fcb0af
Reviewed-on: https://chromium-review.googlesource.com/708736
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508391}
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSuggestion.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageLoadTest.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/resources/local_ntp/most_visited_single.js
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/search/instant_service.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/ui/search/ntp_user_data_logger_unittest.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/common/instant_struct_traits.h
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/common/search/instant_types.h
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/renderer/resources/extensions/searchbox_api.js
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/renderer/searchbox/searchbox_extension.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeMostVisitedSites.java
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/metrics.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/metrics_unittest.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/ntp_tile.h
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/ntp_tile_impression.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/ntp_tiles/ntp_tile_impression.h
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/suggestions/blacklist_store.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/suggestions/blacklist_store_unittest.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/suggestions/suggestions_store.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/components/suggestions/suggestions_store_unittest.cc
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.mm
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/ios/chrome/browser/content_suggestions/ntp_home_mediator.mm
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
[modify] https://crrev.com/a0f98cc9956e6a634c846d2450fa68bbfd3769da/tools/metrics/histograms/histograms.xml

Comment 5 by mastiz@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment