New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763944 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

ClangToT bots failing with new -Wenum-compare warnings

Project Member Reported by h...@chromium.org, Sep 11 2017

Issue description

Richard enhanced the warning in Clang r312842

From https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/9074

FAILED: obj/third_party/libxml/libxml/xpath.o 
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/libxml/libxml/xpath.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"312916\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../../third_party/libxml/linux -I../.. -Igen -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/zlib -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-pointer-sign -Wno-empty-body -Wno-tautological-pointer-compare -Wno-ignored-attributes -Wno-int-to-void-pointer-cast -Wno-incompatible-pointer-types -Wno-unused-function -DLIBXML_STATIC= -std=gnu11 --sysroot=../../build/linux/debian_jessie_amd64-sysroot -c ../../third_party/libxml/src/xpath.c -o obj/third_party/libxml/libxml/xpath.o
../../third_party/libxml/src/xpath.c:12420:28: error: comparison of two values with different enumeration types ('xmlElementType' and 'xmlXPathTypeVal') [-Werror,-Wenum-compare]
                    } else if (cur->type == type) {
                               ~~~~~~~~~ ^  ~~~~
1 error generated.




Let's see how widespread this is. If it's just that one, perhaps disabling the warning for libxml makes sense.
 

Comment 1 by h...@chromium.org, Sep 11 2017

Owner: h...@chromium.org
Status: Assigned (was: Available)
The xpath.c warning appears to be the only one firing for the 'chrome' target. I'll disable it there for now..
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff4821501279b5868877ac32df41fbfc1cfc7907

commit ff4821501279b5868877ac32df41fbfc1cfc7907
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Sep 11 17:20:46 2017

Disable -Wenum-compare for third_party/libxml

The warning got more aggressive in new versions of Clang. Let's disable
it for now.

BUG= 763944 
TBR=thakis,rnk

Change-Id: Ia24c87908f0302f9ea7123a4635a429d3cc65e77
Reviewed-on: https://chromium-review.googlesource.com/660798
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500943}
[modify] https://crrev.com/ff4821501279b5868877ac32df41fbfc1cfc7907/third_party/libxml/BUILD.gn

Comment 3 by h...@chromium.org, Sep 11 2017

Cc: ecbeckmann@chromium.org

Comment 4 by h...@chromium.org, Sep 11 2017

Status: Fixed (was: Assigned)
I did a full debug build, and there were no more warnings.

Looking at libxml2, there was a warning here in the past:
https://github.com/GNOME/libxml2/commit/713434d2309da469d64b35e163ea6556dadccada

I'll let upstream know, but I don't think there's more to be done by us here.

Sign in to add a comment