ContentSuggestions accessibility scroll is too big |
||
Issue descriptionWhat steps will reproduce the problem? (1) Activate VoiceOver (2) Open a NTP with ContentSuggestions (3) Scroll down What is the expected result? The first unseen article should be at the top of the screen. What happens instead? The article is displayed below the omnibox, hidden by it.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6402bf22946dc0fe10350f1987a252a70525063 commit e6402bf22946dc0fe10350f1987a252a70525063 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Sep 12 16:16:41 2017 Adjust ContentSuggestions accessibility scrolling When the user scrolls with voice over activated, the scroll is done by increasing the collection scroll by the height of the collection view. As the collection is displaying the fake omnibox as an overlay, the content hidden by the omnibox is not taken into account by the default computation. This CL fixes it by taking it into account. Bug: 763940 Change-Id: I3111037cbee73521096bbe9dbe264d809ac5088c Reviewed-on: https://chromium-review.googlesource.com/660220 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501295} [modify] https://crrev.com/e6402bf22946dc0fe10350f1987a252a70525063/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Sep 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by fi...@chromium.org
, Sep 11 2017