New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763933 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ junov@chromium.org
xidac...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 766019
Blocking:
issue 634542



Sign in to add a comment

Remove "Failure" for non-srgb wpt tests from TestExpecatations

Project Member Reported by zakerinasab@chromium.org, Sep 11 2017 
These wpt layout tests are excluded in TestExpectations as they are using a generic RGB image as the source, leading them to fail after color correct rendering is turned on:

 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_1.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_2.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_3.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_4.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_5.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_6.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_7.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_8.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_10.html [ Failure ]
 crbug.com/733274  external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_svg_image_1.html [ Failure ]
 crbug.com/733274  virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-repeat-with-transformations.html [ Failure ]
 crbug.com/733274  virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas.html [ Failure ]

See if we can add a check inside the layout test to bypass if color correct rendering is supported.

Comment 1 by zakerinasab@chromium.org, Sep 11 2017 

The primary idea was to do an API check and bypass the test, like if ctx.getContextAttributes().colorSpace is defined. However, we can't do this as these are reference tests.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22b7b2b53a628b52b3ba3deccd00129551a49de

commit b22b7b2b53a628b52b3ba3deccd00129551a49de
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Mon Sep 11 17:24:32 2017

Update reference bug for wpt tests failing due to color correct rendering

This change updates the reference bug for some layout tests that are
failing because they are using a non-srgb image source.

Bug:763933
Change-Id: If9d5ec92c510788c2ab6bf6e57126d76d5267715

TBR=junov@chromium.org

Change-Id: If9d5ec92c510788c2ab6bf6e57126d76d5267715
Reviewed-on: https://chromium-review.googlesource.com/660657
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500951}
[modify] https://crrev.com/b22b7b2b53a628b52b3ba3deccd00129551a49de/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by zakerinasab@chromium.org, Sep 18 2017

Blockedon: 766019
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d3c601cfc71f45fe2514add64bb87254f3b2b6f

commit 4d3c601cfc71f45fe2514add64bb87254f3b2b6f
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Mon Sep 25 15:18:18 2017

Refactor wpt/2dcontext/drawing-images-to-the-canvas/ layout tests:

This change refactors wpt/2dcontext/drawing-images-to-the-canvas/ layout tests:

- Merge the similar layout tests where the only difference is the color space of the source image (generic RGB vs sRGB)
- Replace reference tests with proper testharness tests
- Investigate the layout tests that are failing on Chromium

Bug:  766019 ,  765270 ,  765312 ,  763933 
Change-Id: Icd995d7c2752ea42440147cca1d1921ef3c797d9
Reviewed-on: https://chromium-review.googlesource.com/670023
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504057}
[modify] https://crrev.com/4d3c601cfc71f45fe2514add64bb87254f3b2b6f/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/2x2-srgb.png
[modify] https://crrev.com/4d3c601cfc71f45fe2514add64bb87254f3b2b6f/third_party/WebKit/LayoutTests/external/wpt/2dcontext/2x2.png
[add] https://crrev.com/4d3c601cfc71f45fe2514add64bb87254f3b2b6f/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_1.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_10.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_10_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_11.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_11_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_12.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_12_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_1_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_2.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_2_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_3.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_3_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_4.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_4_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_5.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_5_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_6.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_6_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_7.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_7_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_8.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_8_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_9.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_9_ref.html
[add] https://crrev.com/4d3c601cfc71f45fe2514add64bb87254f3b2b6f/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_1.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_10.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_10_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_10_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_11.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_11_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_12.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_12_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_13.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_13_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_14.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_14_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_15.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_15_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_1_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_1_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_2.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_2_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_2_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_3.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_3_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_3_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_4.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_4_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_4_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_5.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_5_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_5_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_6.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_6_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_6_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_7.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_7_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_7_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_8.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_8_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_8_srgb.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_9.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_9_ref.html
[modify] https://crrev.com/4d3c601cfc71f45fe2514add64bb87254f3b2b6f/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_svg_image_1.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_svg_image_1_ref.html
[delete] https://crrev.com/35795ad419725909b9b2d44e3da5b8cc9c895f2e/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_svg_image_1_srgb.html

Comment 5 by zakerinasab@chromium.org, Sep 26 2017

Status: Fixed (was: Assigned)

Comment 6 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment