add timeout to onSurfaceDestroyed in AndroidOverlay |
||
Issue descriptionDialogOverlayCore shouldn't block indefinitely waiting for the client. it should unblock after a second or two. while nothing will deadlock, it's not a good idea to keep android waiting forever. AVDA / MCVD can post the overlay through an allocator thread, which might be hung, during destruction in pre-M devices in response to OSD. that shouldn't prevent it from being freed.
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1df0363610feba56296992d0f3be9bf9363c73cf commit 1df0363610feba56296992d0f3be9bf9363c73cf Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Oct 03 20:59:28 2017 Add timeout for AndroidOverlay surface destruction. Wait up to two seconds for the client to clean up the overlay before allowing onSurfaceDestroyed to proceed. This mirrors what we did before for ContentVideoView in AVDACodecAllocator. Bug: 763929 Change-Id: I96b5d05a58e1a069c40de7c582d84016cd3b30ed Reviewed-on: https://chromium-review.googlesource.com/660797 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506171} [modify] https://crrev.com/1df0363610feba56296992d0f3be9bf9363c73cf/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayCore.java [modify] https://crrev.com/1df0363610feba56296992d0f3be9bf9363c73cf/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayImpl.java [modify] https://crrev.com/1df0363610feba56296992d0f3be9bf9363c73cf/content/public/android/java/src/org/chromium/content/browser/androidoverlay/ThreadHoppingHost.java [modify] https://crrev.com/1df0363610feba56296992d0f3be9bf9363c73cf/content/public/android/junit/src/org/chromium/content/browser/androidoverlay/DialogOverlayCoreTest.java
,
Oct 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, Oct 3 2017