DeviceConditions.class Call requires API level 21 (current min is 16): `android.os.PowerManager#isPowerSaveMode`: NewApi |
||
Issue descriptionorg/chromium/chrome/browser/offlinepages/DeviceConditions.class Call requires API level 21 (current min is 16): `android.os.PowerManager#isPowerSaveMode`: NewApi [warning] Introduced in e33804dac7a75cd090d3bfcca7a1b5f9c2538403 I will add a temporary local suppression with a TODO in https://chromium-review.googlesource.com/c/chromium/src/+/652964
,
Sep 11 2017
The warning is correct, it just was turned off for a couple weeks while we updated platform tools. Unfortunately it let in a lot of API usages like this one. See this for an example fix: https://crbug.com/762550
,
Sep 11 2017
Unless you know the code is going to be called and gated on API level 21 (which on a cursory look it isn't), then that will crash for users on lower API levels when called (assuming it wasn't a private API before in which case it's still bad practice to call it but won't crash).
,
Sep 11 2017
This is crashing Canary, so we are reverting the original.
,
Sep 13 2017
Please remove the suppression if it is still there, either in reland or another CL.
,
Sep 13 2017
It was removed, we will make a correct API call when the reland comes.
,
Sep 13 2017
Sounds great, thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by dewittj@chromium.org
, Sep 11 2017