New issue
Advanced search Search tips

Issue 763902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.7%-8.1% regression in system_health.memory_mobile at 500796:500805

Project Member Reported by rmcilroy@chromium.org, Sep 11 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 11 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=763902

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fcfbe3c486a434cd3eed4c83a4999ff2f7d35cb1e65f36065328e0573e53fb1e


Bot(s) for this bug's original alert(s):

android-nexus5X
android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 11 2017

Cc: chrishtr@chromium.org
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author chrishtr@chromium.org ===

Hi chrishtr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Chris Harrelson
  Commit : c04d0400eca86add0f5f198343b6cffae87d0b78
  Date   : Sat Sep 09 20:10:16 2017
  Subject: Turn off mask tiling.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_news/load_news_irctc
  Change       : 8.86% | 75662318.6667 -> 82368215.3333

Revision             Result                   N
chromium@500795      75662319 +- 3799108      6      good
chromium@500799      76344407 +- 3892193      6      good
chromium@500801      74092371 +- 3121927      6      good
chromium@500802      82368215 +- 1701703      6      bad       <--

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968746493505931168


For feedback, file a bug with component Speed>Bisection
Owner: sunxd@chromium.org
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Sep 12 2017

Issue 763904 has been merged into this issue.

Comment 6 by mustaq@chromium.org, Sep 12 2017

FYI: My quick look at a good fraction (~25%) of the regressions seems to suggests that only a handful of the regressions need attention.  Most of them revert previous improvements hence can be ignored.
sunxd: have you had a chance to look into this yet?

Comment 8 by sunxd@chromium.org, Oct 18 2017

We previously enabled mask tiling which would save mask memory usage by reducing texture size. It got reverted due to a regression bug and this alert was fired. I'm still working on regression bugs and will hopefully re-enable it in M64.

Comment 9 by sunxd@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)
Now that mask tiling is re-enabled. I will mark this as fixed.

Sign in to add a comment