New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763894 link

Starred by 1 user
Status: Assigned
Owner:
stkhapugin@chromium.org
Cc:
jdonnelly@chromium.org
ios-bugs@chromium.org
█ dschuyler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove <b> tag stripping once the JSON parsing class handles HTML tags.

Project Member Reported by stkhapugin@chromium.org, Sep 11 2017 
This is a bug for a TODO left in omnibox_popup_material_view_controller. The <b>, </b> tags are stripped by hand from the omnibox textfield string. This should be handled by JSON parsing class (per comment).

Comment 1 by mpear...@chromium.org, Sep 12 2017

Components: -UI>Browser>Omnibox UI>Browser>Omnibox>AiS
Labels: Hotlist-CodeHealth

Comment 2 by jdonnelly@chromium.org, Jul 27 

Note that the name referenced above no longer exists. The TODO in question is now in omnibox_popup_cell.mm:

https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Due to the fix for  https://crbug.com/721820  we're not actually using the server-provided bolding anymore. It could theoretically still be used in the future, but we should probably remove the <b> tag stripping.

Comment 3 by stkhapugin@chromium.org, Sep 10

Owner: stkhapugin@chromium.org
Status: Started (was: Assigned)

Comment 4 by stkhapugin@chromium.org, Sep 12

Labels: Needs-Feedback
Status: Assigned (was: Started)
The <b> tag is still present! Justin, I believe this is unexpected?
Simulator Screen Shot - iPhone SE - 2018-09-12 at 11.16.18.png
108 KB View Download
►

Sign in to add a comment