Choose appropriate icon size dynamically on different platforms. Here we choose a large ideal icon size to be big enough for all platforms. Note that we only scale down for this icon size but not scale up.
FYI, the install banner is using 144px on Android. https://cs.chromium.org/chromium/src/chrome/browser/installable/installable_manager.cc?type=cs&sq=package:chromium&l=35
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/850aa48403481322fb048d26983a7d042443f98f commit 850aa48403481322fb048d26983a7d042443f98f Author: Jinho Bang <jinho.bang@samsung.com> Date: Wed Sep 20 02:03:19 2017 PaymentHandler: Should pass 'type' and 'sizes' from renderer to browser. In the current implementation, we don't pass an image size and mime type from renderer to browser. When choosing best icon for display, last icon in the list is always selected. So, we should pass 'type' and 'sizes' member to browser and then consider them when choosing icon. Bug: 763886 Change-Id: Icaf297288a7da1d3c605ac9c21aa8a20af0f2af3 Reviewed-on: https://chromium-review.googlesource.com/670225 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#503025} [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/content/browser/payments/payment_app.proto [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/content/browser/payments/payment_app_database.cc [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html [add] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/LayoutTests/http/tests/payments/resources/icon-1x.png [add] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/LayoutTests/http/tests/payments/resources/icon-2x.png [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/Source/modules/payments/ImageObject.idl [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp [modify] https://crrev.com/850aa48403481322fb048d26983a7d042443f98f/third_party/WebKit/public/platform/modules/payments/payment_app.mojom
Comment 1 by jinho.b...@samsung.com
, Sep 11 2017Owner: jinho.b...@samsung.com
Status: Assigned (was: Untriaged)