New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763854 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 713222
issue 763029



Sign in to add a comment

Remove disabling decorator of system health stories

Project Member Reported by nedngu...@google.com, Sep 11 2017

Issue description

We fully migrated system health stories disabling to Expectation, hence this code is no longer needed. It also interferes with CanRunOnBrowser.


 
Blocking: 713222
Labels: -Pri-3 Pri-1
+infinity
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c829ec04abeb4bccb72a8bf142ef52252876e1b0

commit c829ec04abeb4bccb72a8bf142ef52252876e1b0
Author: rnephew <rnephew@chromium.org>
Date: Mon Sep 11 23:31:30 2017

[Telemetry] Get rid of system health specific shared page state.

Before it was used to be able to disable specific system health stories. This
feature is now done via StoryExpectations for all benchmark types so this
special shared page state is no longer required.

Bug:  763854 ,  763029 
Change-Id: Ibf77fe68c2ce964eeaf9f8f6ebdb4c7ee41f1029
Reviewed-on: https://chromium-review.googlesource.com/661326
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501095}
[modify] https://crrev.com/c829ec04abeb4bccb72a8bf142ef52252876e1b0/tools/perf/page_sets/system_health/platforms.py
[modify] https://crrev.com/c829ec04abeb4bccb72a8bf142ef52252876e1b0/tools/perf/page_sets/system_health/system_health_story.py

Status: Fixed (was: Assigned)

Sign in to add a comment