Issue metadata
Sign in to add a comment
|
Regression: Space between focus ring of 'View site info' and omnibox url is not seen proper.
Reported by
db...@etouch.net,
Sep 11 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3212.0 Revision c3a3481c4b1b08775b477144d1d2873a2a3d9900-refs/heads/master@{#500792}(64 bit) OS: Mac(10.11.6,10.12.3,10.12.5). URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca?hl=en What steps will reproduce the problem? (1) Launch chrome, navigate to above URL and click on ADD TO CHROME button. (2) Then open task manager, end the process of new added extension (3) Now press Tab key upto focus reaches to 'View site info' icon and observe focus ring. Actual: Space between focus ring of 'View site info'and omnibox url is not seen proper. Expected: Space between focus ring and omnibox url is not proper. This is a regression issue, broken in 'M-63', will soon update the other info: Good Build:63.0.3205.0 Bad Build: 63.0.3207.0 Note: Issue is not seen on Windows and Linux OS.
,
Sep 11 2017
Using the per-revision bisect providing the bisect results, Good build:63.0.3205.0(Revision:499422). Bad build:63.0.3207.0(Revision:499829). You are probably looking for a change made after 499658 (known good), but no later than 499659 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/77b0453156f99cfcef1918b13a943a2780178882..8a5931edaf7704fceb9d1d7bed291576bd5f9b5f From the CL above, assigning the issue to the concern owner @spqchan : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-URL: https://chromium-review.googlesource.com/636753 Note :Mac specific issue and Able to reproduce in latest Canary #63.0.3212.0
,
Sep 21 2017
,
Sep 21 2017
Working as intended. The previous behavior (the divider and extra space) was incorrect
,
Sep 21 2017
spqchan@, that's surprising that this is WAI - can you link the spec or discussion that says the divider should not be visible in this case?
,
Sep 21 2017
There shouldn't be a divider or extra spacing if it's just an image. It should act like the other "icon only" decorations on the left side. There's no text so it looks really off with a divider and extra space. I don't have the exact specs of this but I can ask UI about it. Alternatively, are you saying it should have text? In that case, that's a different bug. I can create and assign a new one.
,
Sep 21 2017
I'm not saying it should have text (I have no opinion about that). I would, though, like to see the spec that says there should be no divider in this case (or someone from UX confirm). As a user the divider separates the text portion from the informative far-left section of the onmibox. It's strange to allow the two sections to merge back into a single visual unit just because there's no text label on the far left.
,
Sep 21 2017
+maxwalker@ can you address #7? Thanks |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 11 2017Status: Untriaged (was: Unconfirmed)