Issue metadata
Sign in to add a comment
|
Regression: Blue Focus ring gets chopped on chrome://history
Reported by
shruti.j...@etouch.net,
Sep 11 2017
|
||||||||||||||||||||||
Issue description
Chrome Version: 63.0.3212.0 (Official Build) canaryc3a3481c4b1b08775b477144d1d2873a2a3d9900-refs/heads/master@{#500792} (64-bit)
OS: Mac(10.11.6, 10.12.3,10.12.5)
Pre- condition:There should be at least one entry in history list
What steps will reproduce the problem?
(1)launch chrome navigate to chrome://history
(2)Now press Tab key to bring focus to the first entry label and observe focus highlight
Actual :Focus highlight appears chopped from LHS
Expected:Focus highlight should be seen properly
This is regression issue, broken in ‘M 60’ and will soon update other info:
Good build:60.0.3100.0
Bad build: 60.0.3110.0
Note: The above issue is not seen on Win and Linux OS.
,
Sep 11 2017
,
Sep 11 2017
Using the per-revision bisect providing the bisect results, Good build:60.0.3100.0(Revision:471639). Bad build:60.0.3110.0(Revision:474499). You are probably looking for a change made after 474277 (known good), but no later than 474278 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/dab01f63227a6d23fa61445444f0ae129c874686..eac1506ac1502a44f10c1af30d0c4de6d7490a6b From the CL above, assigning the issue to the concern owner @robhogan: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-URL: https://codereview.chromium.org/2896363003 Note : Mac Specific issue and Able to reproduce in latest Canary #63.0.3212.0
,
Sep 11 2017
The rendering is correct. The focused element has overflow:hidden, and the focus right is clipped to the bounds of the focused element as expected. The focus ring was not clipped before the CL because we didn't apply the clip correctly. To avoid the clipping, we can add "margin-left: 2px" to .website-title. @calamity can you try this?
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22f1ba3cc9d7e6cb7f2f2f5379d722b0e24f4dfc commit 22f1ba3cc9d7e6cb7f2f2f5379d722b0e24f4dfc Author: Christopher Lam <calamity@chromium.org> Date: Thu Sep 21 06:54:51 2017 [MD History] Fix clipped outline on item title focus. Bug: 763838 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c777702e8c061d3f972968ed89d6022fcbbd755 Reviewed-on: https://chromium-review.googlesource.com/661979 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#503373} [modify] https://crrev.com/22f1ba3cc9d7e6cb7f2f2f5379d722b0e24f4dfc/chrome/browser/resources/md_history/shared_style.html
,
Sep 22 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Sep 11 201738.8 KB
38.8 KB View Download
39.1 KB
39.1 KB View Download