Currently, many layout tests are issuing a preflight just because it's subject to the CORS RFC 1918. It looks this might be preventing some tests from exercising non-preflight code path leading to less code coverage. We should fix this.
This came up to me when I was reviewing access-control-sandboxed-iframe-denied-expected.txt being which is being removed. It contains a console error mentioning "preflight". https://chromium-review.googlesource.com/c/chromium/src/+/647955
Yes. We should move the flag off `experimental`. Sorry for the cruft.
g
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3 commit c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3 Author: Mike West <mkwst@chromium.org> Date: Mon Sep 18 12:33:24 2017 Disable the 'CorsRfc1918' flag. The implementation needs to change substantially before we can reasonably ship it, so let's disable the flag for the moment to ensure that we're not corrupting unrelated tests along the way. Bug: 763830 Change-Id: I1fd1cc0f7ffa8f7c4d3faab0b8c5131180063cbe Reviewed-on: https://chromium-review.googlesource.com/659897 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#502558} [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/VirtualTestSuites [delete] https://crrev.com/1dc820d46191e5a48ad22b29264d43435fd5b805/third_party/WebKit/LayoutTests/external/wpt/background-fetch/mixed-content-and-allowed-schemes.https.window-expected.txt [delete] https://crrev.com/1dc820d46191e5a48ad22b29264d43435fd5b805/third_party/WebKit/LayoutTests/external/wpt/background-fetch/port-blocking.https.window-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/addressspace-document-appcache.html [delete] https://crrev.com/1dc820d46191e5a48ad22b29264d43435fd5b805/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/addressspace-document-csp-appcache-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/addressspace-document-csp-appcache.html [delete] https://crrev.com/1dc820d46191e5a48ad22b29264d43435fd5b805/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/internal-to-internal-xhr-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/internal-to-internal-xhr.html [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/http/tests/security/cors-rfc1918/resources/addressspace-test.js [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [add] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/virtual/cors-rfc1918/http/tests/security/cors-rfc1918/README.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp [modify] https://crrev.com/c7eaaad7b14997d8efdcd5da922e3ff8b7f6eef3/third_party/WebKit/Source/platform/runtime_enabled_features.json5
Comment 1 by tyoshino@chromium.org
, Sep 11 2017